Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxes break the build-system abstraction. #3408

Closed
charlielye opened this issue Nov 23, 2023 · 1 comment
Closed

Boxes break the build-system abstraction. #3408

charlielye opened this issue Nov 23, 2023 · 1 comment
Assignees

Comments

@charlielye
Copy link
Contributor

charlielye commented Nov 23, 2023

Boxes seem to have built upon other peoples anti-pattern of having it's own "run_tests" script that needs a whole load of build-system context.

The build-system should provide all you need such that a developer adding a project just:

  • Writes a Dockerfile for their project (and optionally a compose file).
  • Updates the build-manifest.yml
  • Update circleci/config.yml (one day obsolete as will codegen from build_manifest.yml)

In config.yml you run something like cond_run_container or cond_run_compose.
Everything should be taken care of to execute a container, or compose file, which should then run whatever is expected to be run.

This issue requests getting rid of any code that replicates the build-system scripts in favour of the above approach.
Reach out to me if we're in some edge case that makes this not possible!

@charlielye
Copy link
Contributor Author

Resolving as part of: #3727

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants