chore(bb): remove -Wfatal-errors

[ludamad]

Seeking feedback on this one, but it doesn't always feel the most productive to see only one error at a time during refactoring. There's already an error limit of 20, and while the CLI might be a bit more spammed the IDE can comfortably show many errors. Even in CLI cases, it can be productive to work through multiple errors without recompiling.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 4623d916 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,948	868,196	3,449,492
l1_rollup_execution_gas	842,035	3,595,304	22,204,861
l2_block_processing_time_in_ms	2,016 (+2%)	7,604	29,706
note_successful_decrypting_time_in_ms	293	868	3,160
note_trial_decrypting_time_in_ms	97.2	75.7 (+1%)	134 (+1%)
l2_block_building_time_in_ms	13,301	52,528	209,752
l2_block_rollup_simulation_time_in_ms	11,937	47,227	188,742
l2_block_public_tx_process_time_in_ms	1,323 (+1%)	5,168	20,516

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,652	42,500
note_history_successful_decrypting_time_in_ms	2,019	3,959 (-1%)
note_history_trial_decrypting_time_in_ms	120 (-1%)	146 (-18%)
node_database_size_in_bytes	1,633,688	1,103,361
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	762	61,697	18,905
private-kernel-ordering	125 (-1%)	24,297	8,153
base-rollup	1,768	656,311	814
root-rollup	171 (+1%)	4,072	1,097
private-kernel-inner	786	81,568	18,905
public-kernel-private-input	41.1	41,519	18,841
public-kernel-non-first-iteration	25.7	41,497	18,841
merge-rollup	15.1 (-1%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547

[codygunton]

I didn't know this is a thing. Looks like a useful change to me.