Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bb: Investigate different proofs being created when proving key is not manually initilaised #3230

Closed
Maddiaa0 opened this issue Nov 3, 2023 · 2 comments

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Nov 3, 2023

Overview

As shown in #3215 bb will create failing proofs if the proving key is not initialised manually. There is a discrepancy between the init implementations and the create_proof init that should be lined up

As described by @charlielye

When calling prove_and_verify, we are always creating the circuit/pk with the witness data and flag not set. prove_and_verify is guaranteed not to fail in this regard. It's faster as it only builds the circuit once, but exposes us to this class of error.

@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 3, 2023
@kevaundray
Copy link
Contributor

Related to #1831

@Maddiaa0
Copy link
Member Author

Maddiaa0 commented Oct 2, 2024

this was a discrepancy between running the circuit builder at vk time with a dummy circuit and proving time, this has since been fixed

@Maddiaa0 Maddiaa0 closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants