Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exposing PXE.getBlock, exporting createAztecNodeClient from aztec.js #3139

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Oct 31, 2023

A few fixes of issues which were stumbled upon by a grantee @harshnambiar.

Issues:

  1. getBlock method was not exposed on PXE even though it's implemented in PXEService,
  2. createAztecNodeRpcClient naming is not consistent with createPXEClient (createAztecNodeRpcClient --> createAztecNodeClient),
  3. createAztecNodeClient method is not exposed in aztec.js.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan marked this pull request as draft October 31, 2023 09:10
@benesjan benesjan marked this pull request as ready for review October 31, 2023 09:46
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (32): 92.0 (+51%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit db67aa1e and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,900 868,148 3,449,504
l1_rollup_execution_gas 841,987 3,595,256 22,204,873
l2_block_processing_time_in_ms 2,076 (+3%) 7,671 (+1%) 29,706
note_successful_decrypting_time_in_ms 297 (+3%) 883 (+4%) 3,146 (-2%)
note_trial_decrypting_time_in_ms 100 (+8%) ⚠️ 92.0 (+51%) 135 (-1%)
l2_block_building_time_in_ms 13,180 52,597 (+1%) 210,076
l2_block_rollup_simulation_time_in_ms 11,863 47,351 (+1%) 189,062 (+1%)
l2_block_public_tx_process_time_in_ms 1,276 5,117 20,524

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 21,445 (-1%) 41,881 (-1%)
note_history_successful_decrypting_time_in_ms 1,985 (-3%) 3,878 (-3%)
note_history_trial_decrypting_time_in_ms 119 (-2%) 142 (-24%)
node_database_size_in_bytes 1,631,244 1,099,288
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 72.3 61,697 18,841
private-kernel-ordering 43.4 24,233 8,089
base-rollup 1,771 656,309 811
root-rollup 77.4 4,072 1,097
private-kernel-inner 52.9 (-1%) 81,504 18,841
public-kernel-private-input 41.3 41,455 18,841
public-kernel-non-first-iteration 26.3 (-1%) 41,497 18,841
merge-rollup 0.935 (+3%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,240

@benesjan benesjan merged commit 7af345e into master Oct 31, 2023
4 checks passed
@benesjan benesjan deleted the janb/fixes branch October 31, 2023 10:06
alexghr pushed a commit that referenced this pull request Oct 31, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.13.1</summary>

##
[0.13.1](aztec-packages-v0.13.0...aztec-packages-v0.13.1)
(2023-10-31)


### Bug Fixes

* Exposing `PXE.getBlock`, exporting `createAztecNodeClient` from
`aztec.js`
([#3139](#3139))
([7af345e](7af345e))
* Revert push cli docker image to docker hub
([#3142](#3142))
([7119382](7119382))
</details>

<details><summary>barretenberg.js: 0.13.1</summary>

##
[0.13.1](barretenberg.js-v0.13.0...barretenberg.js-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.13.1</summary>

##
[0.13.1](barretenberg-v0.13.0...barretenberg-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Nov 7, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.13.1</summary>

##
[0.13.1](AztecProtocol/aztec-packages@aztec-packages-v0.13.0...aztec-packages-v0.13.1)
(2023-10-31)


### Bug Fixes

* Exposing `PXE.getBlock`, exporting `createAztecNodeClient` from
`aztec.js`
([#3139](AztecProtocol/aztec-packages#3139))
([7af345e](AztecProtocol/aztec-packages@7af345e))
* Revert push cli docker image to docker hub
([#3142](AztecProtocol/aztec-packages#3142))
([7119382](AztecProtocol/aztec-packages@7119382))
</details>

<details><summary>barretenberg.js: 0.13.1</summary>

##
[0.13.1](AztecProtocol/aztec-packages@barretenberg.js-v0.13.0...barretenberg.js-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.13.1</summary>

##
[0.13.1](AztecProtocol/aztec-packages@barretenberg-v0.13.0...barretenberg-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants