-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exposing PXE.getBlock
, exporting createAztecNodeClient
from aztec.js
#3139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
|
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.1</summary> ## [0.13.1](aztec-packages-v0.13.0...aztec-packages-v0.13.1) (2023-10-31) ### Bug Fixes * Exposing `PXE.getBlock`, exporting `createAztecNodeClient` from `aztec.js` ([#3139](#3139)) ([7af345e](7af345e)) * Revert push cli docker image to docker hub ([#3142](#3142)) ([7119382](7119382)) </details> <details><summary>barretenberg.js: 0.13.1</summary> ## [0.13.1](barretenberg.js-v0.13.0...barretenberg.js-v0.13.1) (2023-10-31) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.13.1</summary> ## [0.13.1](barretenberg-v0.13.0...barretenberg-v0.13.1) (2023-10-31) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.1</summary> ## [0.13.1](AztecProtocol/aztec-packages@aztec-packages-v0.13.0...aztec-packages-v0.13.1) (2023-10-31) ### Bug Fixes * Exposing `PXE.getBlock`, exporting `createAztecNodeClient` from `aztec.js` ([#3139](AztecProtocol/aztec-packages#3139)) ([7af345e](AztecProtocol/aztec-packages@7af345e)) * Revert push cli docker image to docker hub ([#3142](AztecProtocol/aztec-packages#3142)) ([7119382](AztecProtocol/aztec-packages@7119382)) </details> <details><summary>barretenberg.js: 0.13.1</summary> ## [0.13.1](AztecProtocol/aztec-packages@barretenberg.js-v0.13.0...barretenberg.js-v0.13.1) (2023-10-31) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.13.1</summary> ## [0.13.1](AztecProtocol/aztec-packages@barretenberg-v0.13.0...barretenberg-v0.13.1) (2023-10-31) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
A few fixes of issues which were stumbled upon by a grantee @harshnambiar.
Issues:
getBlock
method was not exposed onPXE
even though it's implemented inPXEService
,createAztecNodeRpcClient
naming is not consistent withcreatePXEClient
(createAztecNodeRpcClient
-->createAztecNodeClient
),createAztecNodeClient
method is not exposed inaztec.js
.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.