Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ProverPlookupAuxiliaryWidget kernel bench #2924

Merged
merged 10 commits into from
Oct 24, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Oct 18, 2023

  • Refactor common code in ProverPlookupAuxiliaryWidget widget bench
  • Bench ProverPlookupAuxiliaryWidget single relation pass as this relates more to the relation benchmarks

@ludamad ludamad changed the title feat: widget kernel bench feat: ProverPlookupAuxiliaryWidget kernel bench Oct 18, 2023
@ludamad ludamad added the crypto cryptography label Oct 18, 2023
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 18, 2023

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit db3fa62e and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,864 868,292 3,448,016
l1_rollup_execution_gas 841,951 3,595,400 22,203,385
l2_block_processing_time_in_ms 1,048 (+3%) 3,979 (+2%) 15,627 (+2%)
note_successful_decrypting_time_in_ms 342 (+1%) 1,056 (+1%) 4,024 (+2%)
note_trial_decrypting_time_in_ms 46.0 (+18%) 108 136 (-1%)
l2_block_building_time_in_ms 9,039 (+2%) 36,140 (+1%) 159,351 (+2%)
l2_block_rollup_simulation_time_in_ms 6,681 (+2%) 26,686 (+2%) 106,064 (+1%)
l2_block_public_tx_process_time_in_ms 2,319 (+1%) 9,327 52,519 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 11,542 (-5%) 21,846 (-1%)
note_history_successful_decrypting_time_in_ms 2,425 (-6%) 4,852 (+1%)
note_history_trial_decrypting_time_in_ms 122 (-1%) 146 (-4%)
node_database_size_in_bytes 1,664,220 1,202,859
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 47.2 (-1%) 61,697 18,841
private-kernel-ordering 23.2 (-3%) 24,233 8,089
base-rollup 852 639,797 811
root-rollup 38.0 4,072 1,097
private-kernel-inner 42.4 (-3%) 81,504 18,841
public-kernel-private-input 47.9 41,455 18,841
public-kernel-non-first-iteration 31.4 (-1%) 41,497 18,841
merge-rollup 0.884 (+9%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,508

Copy link
Contributor

@codygunton codygunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codygunton codygunton merged commit faffc39 into master Oct 24, 2023
4 checks passed
@codygunton codygunton deleted the ad/feat/widget_kernel_bench branch October 24, 2023 19:21
kevaundray pushed a commit that referenced this pull request Oct 24, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.11.1</summary>

##
[0.11.1](aztec-packages-v0.11.0...aztec-packages-v0.11.1)
(2023-10-24)


### Features

* ProverPlookupAuxiliaryWidget kernel bench
([#2924](#2924))
([faffc39](faffc39))


### Bug Fixes

* **ci:** Publish-bb, use clang 16.04
([#3019](#3019))
([703a964](703a964))
</details>

<details><summary>barretenberg.js: 0.11.1</summary>

##
[0.11.1](barretenberg.js-v0.11.0...barretenberg.js-v0.11.1)
(2023-10-24)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.11.1</summary>

##
[0.11.1](barretenberg-v0.11.0...barretenberg-v0.11.1)
(2023-10-24)


### Features

* ProverPlookupAuxiliaryWidget kernel bench
([#2924](#2924))
([faffc39](faffc39))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0 pushed a commit that referenced this pull request Oct 25, 2023
- Refactor common code in ProverPlookupAuxiliaryWidget widget bench
- Bench ProverPlookupAuxiliaryWidget single relation pass as this
relates more to the relation benchmarks

---------

Co-authored-by: ludamad <[email protected]>
Maddiaa0 pushed a commit that referenced this pull request Oct 25, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.11.1</summary>

##
[0.11.1](aztec-packages-v0.11.0...aztec-packages-v0.11.1)
(2023-10-24)


### Features

* ProverPlookupAuxiliaryWidget kernel bench
([#2924](#2924))
([faffc39](faffc39))


### Bug Fixes

* **ci:** Publish-bb, use clang 16.04
([#3019](#3019))
([703a964](703a964))
</details>

<details><summary>barretenberg.js: 0.11.1</summary>

##
[0.11.1](barretenberg.js-v0.11.0...barretenberg.js-v0.11.1)
(2023-10-24)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.11.1</summary>

##
[0.11.1](barretenberg-v0.11.0...barretenberg-v0.11.1)
(2023-10-24)


### Features

* ProverPlookupAuxiliaryWidget kernel bench
([#2924](#2924))
([faffc39](faffc39))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 27, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.11.1</summary>

##
[0.11.1](AztecProtocol/aztec-packages@aztec-packages-v0.11.0...aztec-packages-v0.11.1)
(2023-10-24)


### Features

* ProverPlookupAuxiliaryWidget kernel bench
([#2924](AztecProtocol/aztec-packages#2924))
([faffc39](AztecProtocol/aztec-packages@faffc39))


### Bug Fixes

* **ci:** Publish-bb, use clang 16.04
([#3019](AztecProtocol/aztec-packages#3019))
([703a964](AztecProtocol/aztec-packages@703a964))
</details>

<details><summary>barretenberg.js: 0.11.1</summary>

##
[0.11.1](AztecProtocol/aztec-packages@barretenberg.js-v0.11.0...barretenberg.js-v0.11.1)
(2023-10-24)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.11.1</summary>

##
[0.11.1](AztecProtocol/aztec-packages@barretenberg-v0.11.0...barretenberg-v0.11.1)
(2023-10-24)


### Features

* ProverPlookupAuxiliaryWidget kernel bench
([#2924](AztecProtocol/aztec-packages#2924))
([faffc39](AztecProtocol/aztec-packages@faffc39))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto cryptography
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants