Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean canary env & fixes #2880

Merged
merged 8 commits into from
Oct 17, 2023
Merged

test: clean canary env & fixes #2880

merged 8 commits into from
Oct 17, 2023

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Oct 16, 2023

Fixes #2695
Also:

  • fix canary flow which has been broken it seems; we were no longer installing the npm packages but rather relying on the project's workspace dependencies.
  • Fix aztec.js build in yarn-project which resulted in missing web artifact main.js in NPM package

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@spypsy spypsy marked this pull request as draft October 16, 2023 17:08
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 16, 2023

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit cb18f455 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 223,020 868,292 3,449,420
l1_rollup_execution_gas 842,107 3,595,400 22,204,789
l2_block_processing_time_in_ms ⚠️ 1,226 (+18%) ⚠️ 4,666 (+17%) ⚠️ 18,557 (+18%)
note_successful_decrypting_time_in_ms ⚠️ 383 (+16%) ⚠️ 1,218 (+20%) ⚠️ 4,572 (+22%)
note_trial_decrypting_time_in_ms ⚠️ 84.0 (+147%) 109 (+1%) 143 (+4%)
l2_block_building_time_in_ms ⚠️ 10,952 (+21%) ⚠️ 43,926 (+21%) ⚠️ 186,413 (+23%)
l2_block_rollup_simulation_time_in_ms ⚠️ 8,170 (+22%) ⚠️ 32,887 (+22%) ⚠️ 130,119 (+22%)
l2_block_public_tx_process_time_in_ms ⚠️ 2,733 (+20%) ⚠️ 10,894 (+19%) ⚠️ 55,405 (+26%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms ⚠️ 15,983 (+12%) 33,729 (+9%)
note_history_successful_decrypting_time_in_ms ⚠️ 2,937 (+24%) ⚠️ 6,064 (+27%)
note_history_trial_decrypting_time_in_ms 127 (+4%) 158 (+8%)
node_database_size_in_bytes 1,650,973 1,193,713
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init ⚠️ 52.2 (+19%) 56,577 14,745
private-kernel-ordering ⚠️ 25.8 (+21%) 20,137 8,089
base-rollup ⚠️ 1,032 (+21%) 631,605 811
root-rollup ⚠️ 45.3 (+19%) 4,072 1,097
private-kernel-inner ⚠️ 42.8 (+18%) 72,288 14,745
public-kernel-private-input ⚠️ 57.4 (+22%) 37,359 14,745
public-kernel-non-first-iteration ⚠️ 34.1 (+21%) 37,401 14,745
merge-rollup ⚠️ 1.15 (+30%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,094

@spypsy spypsy marked this pull request as ready for review October 16, 2023 20:38
@spypsy spypsy changed the title test: clean canary env & canary fixes test: clean canary env & fixes Oct 17, 2023
@spypsy spypsy merged commit 20ad577 into master Oct 17, 2023
4 checks passed
@spypsy spypsy deleted the spy/clean-canary branch October 17, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create fresh environment for canary tests
3 participants