Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copied box nargo toml trailing slash #2819

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

dan-aztec
Copy link
Contributor

@dan-aztec dan-aztec commented Oct 12, 2023

missed this in previous update to make box buildable in monorepo

@dan-aztec dan-aztec requested a review from critesjosh October 12, 2023 10:43
@dan-aztec dan-aztec enabled auto-merge (squash) October 12, 2023 10:47
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 12, 2023

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5585075f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,852 868,172 3,449,696
l1_rollup_execution_gas 841,939 3,595,280 22,205,065
l2_block_processing_time_in_ms 1,009 (-1%) 3,885 (-1%) 15,308 (+1%)
note_successful_decrypting_time_in_ms 323 988 3,635 (+2%)
note_trial_decrypting_time_in_ms 27.0 (+4%) 95.0 (-4%) 138
l2_block_building_time_in_ms 8,948 35,727 150,030 (+1%)
l2_block_rollup_simulation_time_in_ms 6,620 26,440 (-1%) 105,053
l2_block_public_tx_process_time_in_ms 2,288 (+1%) 9,158 (+1%) 44,142 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,267 (+2%) 31,531 (+3%)
note_history_successful_decrypting_time_in_ms 2,378 (+5%) 4,654 (+5%)
note_history_trial_decrypting_time_in_ms 123 (+2%) ⚠️ 181 (-13%)
node_database_size_in_bytes 1,648,819 1,191,560
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 43.2 56,577 14,745
private-kernel-ordering 21.2 (-1%) 20,137 8,089
base-rollup 852 631,605 811
root-rollup 37.8 (-2%) 4,072 1,097
private-kernel-inner 35.1 (-1%) 72,288 14,745
public-kernel-private-input 46.6 (-1%) 37,359 14,745
public-kernel-non-first-iteration 27.8 (-1%) 37,401 14,745
merge-rollup 0.870 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,094

@dan-aztec dan-aztec disabled auto-merge October 12, 2023 14:56
@dan-aztec
Copy link
Contributor Author

pretty sure benchmark is variance... this doesnt affect the backend

@dan-aztec dan-aztec enabled auto-merge (squash) October 12, 2023 15:01
@dan-aztec dan-aztec merged commit ecd2a64 into master Oct 13, 2023
2 checks passed
@dan-aztec dan-aztec deleted the dan/fix-box-nargo-toml branch October 13, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants