feat: Configure sandbox for network #2818

PhilWindle · 2023-10-12T10:21:28Z

This PR enables the sandbox to be used as a full node + PXE on a P2P network.

It also fixes a couple of footguns around chain ID configuration.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

AztecBot · 2023-10-12T10:39:04Z

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5585075f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,996	868,220	3,447,836
l1_rollup_execution_gas	842,083	3,595,328	22,203,205
l2_block_processing_time_in_ms	1,018 (-1%)	3,920	15,374 (+1%)
note_successful_decrypting_time_in_ms	324	986 (-1%)	3,662 (+3%)
note_trial_decrypting_time_in_ms	27.0 (+4%)	95.0 (-4%)	138
l2_block_building_time_in_ms	8,923	35,649 (-1%)	150,195 (+1%)
l2_block_rollup_simulation_time_in_ms	6,619	26,491 (-1%)	105,320 (+1%)
l2_block_public_tx_process_time_in_ms	2,264	9,033 (-1%)	44,250 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,803 (-2%)	30,330 (-1%)
note_history_successful_decrypting_time_in_ms	2,286 (+1%)	4,653 (+5%)
note_history_trial_decrypting_time_in_ms	123 (+2%)	⚠️ 147 (-29%)
node_database_size_in_bytes	1,649,095	1,191,454
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	43.4	56,577	14,745
private-kernel-ordering	21.4	20,137	8,089
base-rollup	850	631,605	811
root-rollup	37.7 (-2%)	4,072	1,097
private-kernel-inner	36.0 (+1%)	72,288	14,745
public-kernel-private-input	46.8	37,359	14,745
public-kernel-non-first-iteration	27.9 (-1%)	37,401	14,745
merge-rollup	0.826 (-5%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,094

spalladino

LGTM! Thanks for including unit (and not e2e) tests. The only concern is about removing the chain id from the configuration.

spalladino · 2023-10-12T19:55:33Z

yarn-project/cli/src/index.ts

      const txHash = await tx.getTxHash();
      debugLogger(`Deploy tx sent with hash ${txHash}`);
      if (wait) {
        const deployed = await tx.wait();
        log(`\nContract deployed at ${deployed.contractAddress!.toString()}\n`);
      } else {
-        log(`\nDeployment transaction hash: ${txHash}\n`);
+        log(`\nContract Address: ${deployMethod.completeAddress?.address.toString() ?? 'N/A'}`);


This API kind of sucks, you shouldn't need to keep the deployMethod around just to get the deployment address. Maybe we should inject it into yarn-project/aztec.js/src/contract_deployer/deploy_sent_tx.ts so you can query it from the tx object directly?

(not a note for this PR, but more of a comment for something we need to change elsewhere)

Yeah I thought it was a bit rubbish. I went ahead and made the change.

spalladino · 2023-10-12T19:57:20Z

yarn-project/sequencer-client/src/config.ts

@@ -62,7 +59,6 @@ export function getConfigEnvVars(): SequencerClientConfig {

  return {
    rpcUrl: ETHEREUM_HOST ? ETHEREUM_HOST : '',
-    chainId: CHAIN_ID ? +CHAIN_ID : 31337, // 31337 is the default chain id for anvil


Why remove the chain id from the configuration? It's usually a good practice to include the chain id as a safeguard to ensure you don't accidentally connect to the wrong network by entering an incorrect RPC URL.

That's a good point. I added the chain Id configuration back in and validate it on Aztec Node creation.

spalladino · 2023-10-12T19:58:25Z

yarn-project/sequencer-client/src/sequencer/sequencer.ts

@@ -156,8 +156,8 @@ export class Sequencer {
      // Only accept processed transactions that are not double-spends,
      // public functions emitting nullifiers would pass earlier check but fail here.
      // Note that we're checking all nullifiers generated in the private execution twice,
-      // we could store the ones already checked and skip them here as an optimization.
-      const processedValidTxs = await this.takeValidTxs(processedTxs);
+      // we could store the ones already checked and skip them here as an optimisation.


Fighting the good fight!

I didn't even know I made that change. :-)

yarn-project/aztec-node/terraform/main.tf

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.11</summary> ## [0.8.11](aztec-packages-v0.8.10...aztec-packages-v0.8.11) (2023-10-13) ### Features * **archiver:** Use registry to fetch searchStartBlock ([#2830](#2830)) ([e5bc067](e5bc067)) * Configure sandbox for network ([#2818](#2818)) ([d393a59](d393a59)) * **docker-sandbox:** Allow forks in sandbox ([#2831](#2831)) ([ed8431c](ed8431c)), closes [#2726](#2726) * Goblin Translator Decomposition relation (Goblin Translator part 4) ([#2802](#2802)) ([3c3cd9f](3c3cd9f)) * Goblin Translator GenPermSort relation (Goblin Translator part 3) ([#2795](#2795)) ([b36fdc4](b36fdc4)) * Goblin translator opcode constraint and accumulator transfer relations (Goblin Translator part 5) ([#2805](#2805)) ([b3d1f28](b3d1f28)) * Goblin Translator Permutation relation (Goblin Translator part 2) ([#2790](#2790)) ([9a354c9](9a354c9)) * Integrate ZeroMorph into Honk ([#2774](#2774)) ([ea86869](ea86869)) * Purge non native token + reorder params in token portal ([#2723](#2723)) ([447dade](447dade)) * Throw compile error if read/write public state from private ([#2804](#2804)) ([a3649df](a3649df)) * Unencrypted log filtering ([#2600](#2600)) ([7ae554a](7ae554a)), closes [#1498](#1498) [#1500](#1500) * Update goblin translator circuit builder (Goblin Translator part 1) ([#2764](#2764)) ([32c69ae](32c69ae)) ### Bug Fixes * Outdated `noir:clean` ([#2821](#2821)) ([2ea199f](2ea199f)) ### Miscellaneous * Benchmark tx sizes in p2p pool ([#2810](#2810)) ([f63219c](f63219c)) * Change acir_tests branch to point to master ([#2815](#2815)) ([73f229d](73f229d)) * Fix typo ([#2839](#2839)) ([5afdf91](5afdf91)) * From < genesis allowed in getBlocks ([#2816](#2816)) ([5622b50](5622b50)) * Remove Ultra Grumpkin flavor ([#2825](#2825)) ([bde77b8](bde77b8)) * Remove work queue from honk ([#2814](#2814)) ([bca7d12](bca7d12)) * Spell check ([#2817](#2817)) ([4777a11](4777a11)) ### Documentation * Slight changes to update portal page ([#2799](#2799)) ([eb65819](eb65819)) * Update aztec_connect_sunset.mdx ([#2808](#2808)) ([5f659a7](5f659a7)) </details> <details><summary>barretenberg.js: 0.8.11</summary> ## [0.8.11](barretenberg.js-v0.8.10...barretenberg.js-v0.8.11) (2023-10-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.11</summary> ## [0.8.11](barretenberg-v0.8.10...barretenberg-v0.8.11) (2023-10-13) ### Features * Goblin Translator Decomposition relation (Goblin Translator part 4) ([#2802](#2802)) ([3c3cd9f](3c3cd9f)) * Goblin Translator GenPermSort relation (Goblin Translator part 3) ([#2795](#2795)) ([b36fdc4](b36fdc4)) * Goblin translator opcode constraint and accumulator transfer relations (Goblin Translator part 5) ([#2805](#2805)) ([b3d1f28](b3d1f28)) * Goblin Translator Permutation relation (Goblin Translator part 2) ([#2790](#2790)) ([9a354c9](9a354c9)) * Integrate ZeroMorph into Honk ([#2774](#2774)) ([ea86869](ea86869)) * Update goblin translator circuit builder (Goblin Translator part 1) ([#2764](#2764)) ([32c69ae](32c69ae)) ### Miscellaneous * Change acir_tests branch to point to master ([#2815](#2815)) ([73f229d](73f229d)) * Remove Ultra Grumpkin flavor ([#2825](#2825)) ([bde77b8](bde77b8)) * Remove work queue from honk ([#2814](#2814)) ([bca7d12](bca7d12)) * Spell check ([#2817](#2817)) ([4777a11](4777a11)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.11</summary> ## [0.8.11](AztecProtocol/aztec-packages@aztec-packages-v0.8.10...aztec-packages-v0.8.11) (2023-10-13) ### Features * **archiver:** Use registry to fetch searchStartBlock ([#2830](AztecProtocol/aztec-packages#2830)) ([e5bc067](AztecProtocol/aztec-packages@e5bc067)) * Configure sandbox for network ([#2818](AztecProtocol/aztec-packages#2818)) ([d393a59](AztecProtocol/aztec-packages@d393a59)) * **docker-sandbox:** Allow forks in sandbox ([#2831](AztecProtocol/aztec-packages#2831)) ([ed8431c](AztecProtocol/aztec-packages@ed8431c)), closes [#2726](AztecProtocol/aztec-packages#2726) * Goblin Translator Decomposition relation (Goblin Translator part 4) ([#2802](AztecProtocol/aztec-packages#2802)) ([3c3cd9f](AztecProtocol/aztec-packages@3c3cd9f)) * Goblin Translator GenPermSort relation (Goblin Translator part 3) ([#2795](AztecProtocol/aztec-packages#2795)) ([b36fdc4](AztecProtocol/aztec-packages@b36fdc4)) * Goblin translator opcode constraint and accumulator transfer relations (Goblin Translator part 5) ([#2805](AztecProtocol/aztec-packages#2805)) ([b3d1f28](AztecProtocol/aztec-packages@b3d1f28)) * Goblin Translator Permutation relation (Goblin Translator part 2) ([#2790](AztecProtocol/aztec-packages#2790)) ([9a354c9](AztecProtocol/aztec-packages@9a354c9)) * Integrate ZeroMorph into Honk ([#2774](AztecProtocol/aztec-packages#2774)) ([ea86869](AztecProtocol/aztec-packages@ea86869)) * Purge non native token + reorder params in token portal ([#2723](AztecProtocol/aztec-packages#2723)) ([447dade](AztecProtocol/aztec-packages@447dade)) * Throw compile error if read/write public state from private ([#2804](AztecProtocol/aztec-packages#2804)) ([a3649df](AztecProtocol/aztec-packages@a3649df)) * Unencrypted log filtering ([#2600](AztecProtocol/aztec-packages#2600)) ([7ae554a](AztecProtocol/aztec-packages@7ae554a)), closes [#1498](AztecProtocol/aztec-packages#1498) [#1500](AztecProtocol/aztec-packages#1500) * Update goblin translator circuit builder (Goblin Translator part 1) ([#2764](AztecProtocol/aztec-packages#2764)) ([32c69ae](AztecProtocol/aztec-packages@32c69ae)) ### Bug Fixes * Outdated `noir:clean` ([#2821](AztecProtocol/aztec-packages#2821)) ([2ea199f](AztecProtocol/aztec-packages@2ea199f)) ### Miscellaneous * Benchmark tx sizes in p2p pool ([#2810](AztecProtocol/aztec-packages#2810)) ([f63219c](AztecProtocol/aztec-packages@f63219c)) * Change acir_tests branch to point to master ([#2815](AztecProtocol/aztec-packages#2815)) ([73f229d](AztecProtocol/aztec-packages@73f229d)) * Fix typo ([#2839](AztecProtocol/aztec-packages#2839)) ([5afdf91](AztecProtocol/aztec-packages@5afdf91)) * From < genesis allowed in getBlocks ([#2816](AztecProtocol/aztec-packages#2816)) ([5622b50](AztecProtocol/aztec-packages@5622b50)) * Remove Ultra Grumpkin flavor ([#2825](AztecProtocol/aztec-packages#2825)) ([bde77b8](AztecProtocol/aztec-packages@bde77b8)) * Remove work queue from honk ([#2814](AztecProtocol/aztec-packages#2814)) ([bca7d12](AztecProtocol/aztec-packages@bca7d12)) * Spell check ([#2817](AztecProtocol/aztec-packages#2817)) ([4777a11](AztecProtocol/aztec-packages@4777a11)) ### Documentation * Slight changes to update portal page ([#2799](AztecProtocol/aztec-packages#2799)) ([eb65819](AztecProtocol/aztec-packages@eb65819)) * Update aztec_connect_sunset.mdx ([#2808](AztecProtocol/aztec-packages#2808)) ([5f659a7](AztecProtocol/aztec-packages@5f659a7)) </details> <details><summary>barretenberg.js: 0.8.11</summary> ## [0.8.11](AztecProtocol/aztec-packages@barretenberg.js-v0.8.10...barretenberg.js-v0.8.11) (2023-10-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.11</summary> ## [0.8.11](AztecProtocol/aztec-packages@barretenberg-v0.8.10...barretenberg-v0.8.11) (2023-10-13) ### Features * Goblin Translator Decomposition relation (Goblin Translator part 4) ([#2802](AztecProtocol/aztec-packages#2802)) ([3c3cd9f](AztecProtocol/aztec-packages@3c3cd9f)) * Goblin Translator GenPermSort relation (Goblin Translator part 3) ([#2795](AztecProtocol/aztec-packages#2795)) ([b36fdc4](AztecProtocol/aztec-packages@b36fdc4)) * Goblin translator opcode constraint and accumulator transfer relations (Goblin Translator part 5) ([#2805](AztecProtocol/aztec-packages#2805)) ([b3d1f28](AztecProtocol/aztec-packages@b3d1f28)) * Goblin Translator Permutation relation (Goblin Translator part 2) ([#2790](AztecProtocol/aztec-packages#2790)) ([9a354c9](AztecProtocol/aztec-packages@9a354c9)) * Integrate ZeroMorph into Honk ([#2774](AztecProtocol/aztec-packages#2774)) ([ea86869](AztecProtocol/aztec-packages@ea86869)) * Update goblin translator circuit builder (Goblin Translator part 1) ([#2764](AztecProtocol/aztec-packages#2764)) ([32c69ae](AztecProtocol/aztec-packages@32c69ae)) ### Miscellaneous * Change acir_tests branch to point to master ([#2815](AztecProtocol/aztec-packages#2815)) ([73f229d](AztecProtocol/aztec-packages@73f229d)) * Remove Ultra Grumpkin flavor ([#2825](AztecProtocol/aztec-packages#2825)) ([bde77b8](AztecProtocol/aztec-packages@bde77b8)) * Remove work queue from honk ([#2814](AztecProtocol/aztec-packages#2814)) ([bca7d12](AztecProtocol/aztec-packages@bca7d12)) * Spell check ([#2817](AztecProtocol/aztec-packages#2817)) ([4777a11](AztecProtocol/aztec-packages@4777a11)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Configure sandbox for network

ed83c3c

PhilWindle added 13 commits October 12, 2023 14:37

Fix chain id

ba8165b

Fix

c7a5e39

Test fix

d9cd0be

Debug

35c65e0

Fix

40fe38d

Got rid of chain id from TF

c8426ed

TF fix

ca7a3a3

Merge branch 'master' into pw/sandbox-net

085f787

Cleanup

da85b53

Cleanup

e2f3a02

Cleanup

9ff3ee2

Test fix

e556f4f

Cleanup

76b42e7

PhilWindle marked this pull request as ready for review October 12, 2023 19:08

spalladino reviewed Oct 12, 2023

View reviewed changes

PhilWindle and others added 4 commits October 12, 2023 20:46

Review changes

0e8cee0

Review changes

f54a1c0

Test fix

5c3ad92

Merge branch 'master' into pw/sandbox-net

ff613fb

alexghr approved these changes Oct 13, 2023

View reviewed changes

PhilWindle enabled auto-merge (squash) October 13, 2023 08:28

PhilWindle merged commit d393a59 into master Oct 13, 2023
2 checks passed

PhilWindle deleted the pw/sandbox-net branch October 13, 2023 08:29

AztecBot mentioned this pull request Oct 13, 2023

chore(master): Release 0.8.11 #2811

Merged

spalladino mentioned this pull request Oct 17, 2023

Get the contract deployment address from a DeploySentTx directly #2894

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Configure sandbox for network #2818

feat: Configure sandbox for network #2818

PhilWindle commented Oct 12, 2023 •

edited

Loading

AztecBot commented Oct 12, 2023 •

edited

Loading

spalladino left a comment

spalladino Oct 12, 2023

PhilWindle Oct 12, 2023

spalladino Oct 12, 2023

PhilWindle Oct 12, 2023

spalladino Oct 12, 2023

PhilWindle Oct 12, 2023

feat: Configure sandbox for network #2818

feat: Configure sandbox for network #2818

Conversation

PhilWindle commented Oct 12, 2023 • edited Loading

Checklist:

AztecBot commented Oct 12, 2023 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

spalladino left a comment

Choose a reason for hiding this comment

spalladino Oct 12, 2023

Choose a reason for hiding this comment

PhilWindle Oct 12, 2023

Choose a reason for hiding this comment

spalladino Oct 12, 2023

Choose a reason for hiding this comment

PhilWindle Oct 12, 2023

Choose a reason for hiding this comment

spalladino Oct 12, 2023

Choose a reason for hiding this comment

PhilWindle Oct 12, 2023

Choose a reason for hiding this comment

PhilWindle commented Oct 12, 2023 •

edited

Loading

AztecBot commented Oct 12, 2023 •

edited

Loading