Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add md to rebuild patterns #2798

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

spalladino
Copy link
Collaborator

The yarn formatting step currently checks md files as well. This means that an incorrectly formatted md file in yarn project will cause the yarn-project-formatting job to fail, but pushing a new commit with the fix won't trigger yarn-project to rebuild, so yarn-project-formatting will keep seeing the malformed md, and will keep failing.

See this workflow run for an example.

The yarn formatting step currently checks md files as well. This means
that an incorrectly formatted md file in yarn project will cause the
yarn-project-formatting job to fail, but pushing a new commit with the
fix won't trigger yarn-project to rebuild, so yarn-project-formatting
will keep seeing the malformed md, and will keep failing.

See [this workflow run](https://app.circleci.com/pipelines/github/AztecProtocol/aztec-packages/13854/workflows/4981ebef-0028-48a3-aa72-b456cba54a9e) for an example.
@spalladino spalladino requested a review from charlielye October 11, 2023 13:01
@ludamad ludamad enabled auto-merge (squash) October 11, 2023 13:14
@ludamad ludamad merged commit 3f4297d into master Oct 11, 2023
2 checks passed
@ludamad ludamad deleted the palla/add-md-to-rebuild-pattern branch October 11, 2023 13:26
@AztecBot
Copy link
Collaborator

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45444 179588 716132
l1_rollup_calldata_gas 222888 868208 3449324
l1_rollup_execution_gas 841975 3595316 22204693
l2_block_processing_time_in_ms 1246 4816 18349
note_successful_decrypting_time_in_ms 386 1246 4480
note_trial_decrypting_time_in_ms 90 109 143
l2_block_building_time_in_ms 11035 44910 186575
l2_block_rollup_simulation_time_in_ms 8267 33789 131310
l2_block_public_tx_process_time_in_ms 2721 10968 54456

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 10 blocks 20 blocks 30 blocks
node_history_sync_time_in_ms 34486 79235 138258
note_history_successful_decrypting_time_in_ms 6038 17564 27734
note_history_trial_decrypting_time_in_ms 157 326 300
node_database_size_in_bytes 1195755 1901678 2755654
pxe_database_size_in_bytes 54187 108338 162578

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 75.22239263803681 56577 14745
private-kernel-ordering 38.34049079754601 20137 8089
base-rollup 1056 631604 810
root-rollup 45.4390243902439 4072 1097
private-kernel-inner 70.49691358024691 72288 14745
public-kernel-private-input 66.29166666666667 37359 14745
public-kernel-non-first-iteration 39.898148148148145 37401 14745
merge-rollup 1.2248062015503876 2592 873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants