Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Fr back as a BB export (ts) #2770

Merged
merged 2 commits into from
Oct 10, 2023
Merged

feat: adding Fr back as a BB export (ts) #2770

merged 2 commits into from
Oct 10, 2023

Conversation

signorecello
Copy link
Contributor

@signorecello signorecello commented Oct 10, 2023

Smallest PR ever. closes #2369

Fr stopped being exported since bb.js 0.0.1, and it's a very useful util class for getting field values from strings, buffers, or to strings and buffers.

We've been getting requests for this from Noir developers, and devrel actually needs this in order to refactor the Stealthdrop example.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@signorecello signorecello changed the title Adding Fr back as a BB export (ts) feat: adding Fr back as a BB export (ts) Oct 10, 2023
@rahul-kothari rahul-kothari self-requested a review October 10, 2023 17:04
@signorecello signorecello merged commit d9ac808 into master Oct 10, 2023
2 checks passed
@signorecello signorecello deleted the zpedro/fr branch October 10, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Export Fr type
2 participants