refactor: no calls to pedersen from TS #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
janb/no-direct-TS-calls-to-pedersen
branch
2 times, most recently
from
2f52953 to
d0d7fa0
Compare
benesjan
force-pushed
the
janb/no-direct-TS-calls-to-pedersen
branch
from
e8099cc to
45b61e6
Compare
PhilWindle
requested changes
Oct 11, 2023
| @@ -10,6 +10,7 @@ import { deserializeArrayFromVector, deserializeField, serializeBufferArrayToVec | |||
| * @param lhs - The first hash. | |||
| * @param rhs - The second hash. | |||
| * @returns The new 32-byte hash. | |||
| * @deprecated Don't call pedersen directly in production code. Instead, create specific nicely-called WASM functions. | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Don't call pedersen directly in production code. Instead, create specific nicely-called WASM functions. | |
| * @deprecated Don't call pedersen directly in production code. Instead, create suitably-named functions for specific purposes. |
There was a problem hiding this comment.
Addressed in 4b722a5
| @@ -3208,7 +3208,7 @@ export function abisComputeGlobalsHash(wasm: IWasmModule, arg0: GlobalVariables) | |||
| export function abisComputePublicDataTreeValue(wasm: IWasmModule, arg0: Fr): Fr { | |||
| return Fr.fromBuffer(callCbind(wasm, 'abis__compute_public_data_tree_value', [toBuffer(arg0)])); | |||
| } | |||
| export function abisComputePublicDataTreeIndex(wasm: IWasmModule, arg0: Fr, arg1: Fr): Fr { | |||
| export function abisComputePublicDataTreeIndex(wasm: IWasmModule, arg0: Address, arg1: Fr): Fr { | |||
There was a problem hiding this comment.
Is this Address or AztecAddress?
There was a problem hiding this comment.
This is correct because of this alias. There is no AztecAddress on the C++ side so I guess Adam set it up like this to make it work.
| @@ -9,22 +9,35 @@ import { Hasher } from '@aztec/types'; | |||
|
|
|||
| /** | |||
| * A helper class encapsulating Pedersen hash functionality. | |||
| * @deprecated Don't call pedersen directly in production code. Instead, create specific nicely-called WASM functions. | |||
There was a problem hiding this comment.
Same suggestion as above.
There was a problem hiding this comment.
Addressed in 4b722a5
PhilWindle
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435
This PR doesn't really address the original issue that much. I have reasons for this:
I marked the pedersen functions as deprecated with a message to not use it in production code. I think that's the best way to go about this at this point.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.