Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reprocess notes in pxe when a new contract is added #2709

Closed
spalladino opened this issue Oct 5, 2023 · 0 comments · Fixed by #3867
Closed

Reprocess notes in pxe when a new contract is added #2709

spalladino opened this issue Oct 5, 2023 · 0 comments · Fixed by #3867
Assignees
@just-mitch
Labels
T-bug Type: Bug. Something is broken.

Comments

@spalladino
Copy link
Collaborator

If a user receives a private note from a contract they haven't yet added to their pxe, note processing will fail since the pxe doesn't have access to the compute_note_hash_and_nullifier function of that contract to decode the note. However, when the contract is later added, the note remains as failed.

We should collect the notes that fail due to missing contract info, and when the contract is added, reprocess them.
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 5, 2023
@alexghr alexghr mentioned this issue Dec 8, 2023
Merged
@just-mitch just-mitch assigned just-mitch and unassigned alexghr Jan 4, 2024
@spalladino spalladino added the T-bug Type: Bug. Something is broken. label Jan 5, 2024
@just-mitch just-mitch linked a pull request Jan 7, 2024 that will close this issue
fix: reprocess notes in pxe when a new contract is added #3867
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@just-mitch just-mitch

Labels
T-bug Type: Bug. Something is broken.
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reprocess notes in pxe when a new contract is added AztecProtocol/aztec-packages
3 participants
@spalladino @alexghr @just-mitch