fix: Deploy npm fixes #2685
Merged
fix: Deploy npm fixes #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
palla/fix-deploy-npm
branch
from
25301ca to
01a08ed
Compare
spalladino
commented
Oct 4, 2023
| @@ -10,7 +10,7 @@ REPOSITORY="$1" | |||
| ERROR_ON_FAIL="${2:-"false"}" | |||
|
|
|||
| # Check if there is a commit tag | |||
| if [[ -z "$COMMIT_TAG" ]]; then | |||
| if [[ -z "${COMMIT_TAG:-}" ]]; then | |||
There was a problem hiding this comment.
This failed due to the set -u
spalladino
commented
Oct 4, 2023
Comment on lines
+24
to
+25
| PUBLISHED_VERSION=$(npm show . version ${TAG_ARG:-} 2> /dev/null) | ||
| HIGHER_VERSION=$(npx semver ${VERSION} ${PUBLISHED_VERSION} | tail -1) |
There was a problem hiding this comment.
The readonly modifier blew up the 2nd time the function was called
spypsy
approved these changes
Oct 4, 2023
spalladino
pushed a commit
that referenced
this pull request
Oct 4, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.4</summary> ## [0.8.4](aztec-packages-v0.8.3...aztec-packages-v0.8.4) (2023-10-04) ### Bug Fixes * `deploy_dockerhub.sh` permissions ([#2682](#2682)) ([628127d](628127d)) * Deploy npm fixes ([#2685](#2685)) ([0b788c6](0b788c6)) * Foundation package is not private ([71d6cda](71d6cda)) </details> <details><summary>barretenberg.js: 0.8.4</summary> ## [0.8.4](barretenberg.js-v0.8.3...barretenberg.js-v0.8.4) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.4</summary> ## [0.8.4](barretenberg-v0.8.3...barretenberg-v0.8.4) (2023-10-04) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Oct 5, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.4</summary> ## [0.8.4](AztecProtocol/aztec-packages@aztec-packages-v0.8.3...aztec-packages-v0.8.4) (2023-10-04) ### Bug Fixes * `deploy_dockerhub.sh` permissions ([#2682](AztecProtocol/aztec-packages#2682)) ([628127d](AztecProtocol/aztec-packages@628127d)) * Deploy npm fixes ([#2685](AztecProtocol/aztec-packages#2685)) ([0b788c6](AztecProtocol/aztec-packages@0b788c6)) * Foundation package is not private ([71d6cda](AztecProtocol/aztec-packages@71d6cda)) </details> <details><summary>barretenberg.js: 0.8.4</summary> ## [0.8.4](AztecProtocol/aztec-packages@barretenberg.js-v0.8.3...barretenberg.js-v0.8.4) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.4</summary> ## [0.8.4](AztecProtocol/aztec-packages@barretenberg-v0.8.3...barretenberg-v0.8.4) (2023-10-04) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0
pushed a commit
that referenced
this pull request
Oct 6, 2023
Fixes to the `deploy_npm` script. We were not `cd`ing into each package, so the script was attempting to publish the root workspace `package.json`.
Maddiaa0
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.4</summary> ## [0.8.4](aztec-packages-v0.8.3...aztec-packages-v0.8.4) (2023-10-04) ### Bug Fixes * `deploy_dockerhub.sh` permissions ([#2682](#2682)) ([628127d](628127d)) * Deploy npm fixes ([#2685](#2685)) ([0b788c6](0b788c6)) * Foundation package is not private ([71d6cda](71d6cda)) </details> <details><summary>barretenberg.js: 0.8.4</summary> ## [0.8.4](barretenberg.js-v0.8.3...barretenberg.js-v0.8.4) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.4</summary> ## [0.8.4](barretenberg-v0.8.3...barretenberg-v0.8.4) (2023-10-04) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to the
deploy_npmscript. We were notcding into each package, so the script was attempting to publish the root workspacepackage.json.