Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't cache contract witnesses #2398

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: Don't cache contract witnesses #2398

merged 1 commit into from
Sep 19, 2023

Conversation

sirasistant
Copy link
Collaborator

@sirasistant sirasistant commented Sep 19, 2023 •
edited
Loading

Resolves #2397

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@sirasistant sirasistant changed the title fix: don't cache contract witnesses fix: Don't cache contract witnesses Sep 19, 2023
@sirasistant sirasistant enabled auto-merge (squash) September 19, 2023 12:24
@sirasistant sirasistant enabled auto-merge (squash) September 19, 2023 12:25
@sirasistant sirasistant merged commit 1092060 into master Sep 19, 2023
4 checks passed
@sirasistant sirasistant deleted the arv/fix_witness_cache branch September 19, 2023 12:28
@AztecBot AztecBot mentioned this pull request Sep 19, 2023
Merged
PhilWindle pushed a commit that referenced this pull request Sep 19, 2023
@AztecBot
chore(master): Release 0.7.9 (#2399)
2c2d947 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.7.9</summary>

##
[0.7.9](aztec-packages-v0.7.8...aztec-packages-v0.7.9)
(2023-09-19)


### Bug Fixes

* Don't cache contract witnesses
([#2398](#2398))
([1092060](1092060)),
closes
[#2397](#2397)
</details>

<details><summary>barretenberg.js: 0.7.9</summary>

##
[0.7.9](barretenberg.js-v0.7.8...barretenberg.js-v0.7.9)
(2023-09-19)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.7.9</summary>

##
[0.7.9](barretenberg-v0.7.8...barretenberg-v0.7.9)
(2023-09-19)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

@spalladino spalladino Awaiting requested review from spalladino

@LeilaWang LeilaWang Awaiting requested review from LeilaWang

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caching membership witnesses of contracts breaks interaction after deployment
2 participants
@sirasistant @PhilWindle