fix: remove non-npm packages from end-to-end during canary flow #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
reviewed
Sep 19, 2023
| for PKG in "${TARGET_PKGS[@]}"; do | ||
| jq --arg v $VERSION ".dependencies[\"$PKG\"] = \$v" package.json > $TMP && mv $TMP package.json | ||
| done | ||
| # for PKG in "${TARGET_PKGS[@]}"; do |
There was a problem hiding this comment.
can remove the commented code
ludamad
reviewed
Sep 19, 2023
| .dependencies |= with_entries( | ||
| select( | ||
| (.key | startswith("@aztec")) as $isAztec | | ||
| if $isAztec then |
There was a problem hiding this comment.
oh boy haha cool but this is where having JS available to use would be nice
ludamad
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we don't use any pre-built
workspacedependences, This script updates canary dependences to the version being released, as well as removing remaining@aztec/packages from package.json