Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove using namespace in barretenberg header files #2216

Open
zac-williamson opened this issue Sep 11, 2023 · 3 comments
Open

Remove using namespace in barretenberg header files #2216

zac-williamson opened this issue Sep 11, 2023 · 3 comments
Labels
C-barretenberg Component: barretenberg cryptography library crypto cryptography

Comments

@zac-williamson
Copy link
Contributor

program_settings.hpp includes header files that added "using namespace proof_system" and "using namespace barretenberg" declarations. This effects downstream code that relies on these using declarations. This is a big code smell (should really not have using declarations in header files!), however fixing it requires changes in a LOT of files.

We likely have using namespace declarations in header files elsewhere in the codebase that need to be removed.

@zac-williamson zac-williamson added crypto cryptography C-barretenberg Component: barretenberg cryptography library labels Sep 11, 2023
@zac-williamson zac-williamson self-assigned this Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 11, 2023
@maramihali
Copy link
Contributor

this PR #2125 removes them

@maramihali
Copy link
Contributor

also it would be better if these issues lived in bberg

@codygunton
Copy link
Contributor

As of 2023-11-21 there are 52 instances 😦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-barretenberg Component: barretenberg cryptography library crypto cryptography
Projects
Status: Todo
Development

No branches or pull requests

3 participants