Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted files are still present in CI runs #2195

Closed
spalladino opened this issue Sep 11, 2023 · 0 comments
Closed

Deleted files are still present in CI runs #2195

spalladino opened this issue Sep 11, 2023 · 0 comments
Labels
A-devops Area: Devops. E.g. CI / build systems

Comments

@spalladino
Copy link
Collaborator

In this run we hit a CI error since a file that was deleted in the PR was present on the CI run. We believe it's because yarn-project-base copies the entire project into the docker image, and then each package builds off of that by COPYing over again the latest version. But if yarn-project-base didn't get rebuilt due to no changes, then it will carry the old set of files (which includes the deleted one), and overwriting the entire project in each package built only overwrites existing files.

We should see if we can remove the COPY . . step from yarn-project-base's Dockerfile, or if we can tweak subsequent COPY . . steps so that it properly deletes files.

As a workaround, triggering a rebuild of yarn-project-base fixes things.

@spalladino spalladino added the A-devops Area: Devops. E.g. CI / build systems label Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 11, 2023
@spalladino spalladino closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Devops. E.g. CI / build systems
Projects
Archived in project
Development

No branches or pull requests

1 participant