Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surprisingly slow cli commands #2184

Closed
iAmMichaelConnor opened this issue Sep 11, 2023 · 0 comments
Closed

Surprisingly slow cli commands #2184

iAmMichaelConnor opened this issue Sep 11, 2023 · 0 comments
Assignees
Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) T-optimisation Type: Optimisation. Making something faster / cheaper / smaller

Comments

@iAmMichaelConnor
Copy link
Contributor

iAmMichaelConnor commented Sep 11, 2023

This should at least be considered and understood before the public launch:

"
A bit surprised the creation of the accounts + waiting for the deploy takes a few seconds..given it’s a local environment i’d hope it’s ~instant. Maybe some polling check can be made tighter? aztec-cli generate-private-key & aztec-cli create-account feel super slow, not sure if it’s bc they do something on-chain, you’d expect account creation is offline and ~instant
"

Creation of an account deploys an account contract, so that will explain some of the slowness. Is there anything that can be done to improve the speeds here?

If not (or if not immediately fixable), perhaps the cli should console.log an explanation that account creation involves deployment. (E.g. deploying account contract...)

Related issue: #1558

@iAmMichaelConnor iAmMichaelConnor added T-optimisation Type: Optimisation. Making something faster / cheaper / smaller A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) labels Sep 11, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 11, 2023
@iAmMichaelConnor iAmMichaelConnor modified the milestone: 📢 Initial Public Sandbox Release Sep 11, 2023
@benesjan benesjan self-assigned this Sep 19, 2023
@PhilWindle PhilWindle moved this from Todo to Done in A3 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) T-optimisation Type: Optimisation. Making something faster / cheaper / smaller
Projects
Archived in project
Development

No branches or pull requests

3 participants