Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Aztec.nr): Implement new context scemantics #2163

Closed
Maddiaa0 opened this issue Sep 10, 2023 · 0 comments · Fixed by #2406
Closed

feat(Aztec.nr): Implement new context scemantics #2163

Maddiaa0 opened this issue Sep 10, 2023 · 0 comments · Fixed by #2406
Labels
C-aztec.nr Component: Aztec smart contract framework

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Sep 10, 2023 •
edited
Loading

Overview

In a recent PR #2143, the context semantics changed. Gobble up these issues in the noir macros
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 10, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Sep 11, 2023
@iAmMichaelConnor iAmMichaelConnor added the C-aztec.nr Component: Aztec smart contract framework label Sep 11, 2023
@Maddiaa0 Maddiaa0 mentioned this issue Sep 11, 2023
Closed
@Maddiaa0 Maddiaa0 mentioned this issue Sep 21, 2023
Merged
Maddiaa0 added a commit that referenced this issue Sep 26, 2023
@Maddiaa0
feat(aztec_noir): abstract storage initialisation (#2406)
974b037 
After a discussion with lasse, decided to get this over the line,
removes the storage init and places it inside the macro expansion

todo:
-  update docs
- release noir

related work:
- noir-lang/noir#2750


fixes: #2163
fixes: #1890
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 26, 2023
AztecBot pushed a commit to AztecProtocol/docs that referenced this issue Sep 27, 2023
@Maddiaa0 @AztecBot
feat(aztec_noir): abstract storage initialisation (#2406)
e6e9637 
After a discussion with lasse, decided to get this over the line,
removes the storage init and places it inside the macro expansion

todo:
-  update docs
- release noir

related work:
- noir-lang/noir#2750


fixes: AztecProtocol/aztec-packages#2163
fixes: AztecProtocol/aztec-packages#1890
@Maddiaa0 Maddiaa0 removed this from A3 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-aztec.nr Component: Aztec smart contract framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aztec_noir): abstract storage initialisation AztecProtocol/aztec-packages
2 participants
@iAmMichaelConnor @Maddiaa0