Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop unnecessary release-please CI builds #2055

Closed
spypsy opened this issue Sep 6, 2023 · 0 comments · Fixed by #3984
Closed

Stop unnecessary release-please CI builds #2055

spypsy opened this issue Sep 6, 2023 · 0 comments · Fixed by #3984
Assignees
@spypsy @just-mitch

Comments

@spypsy
Copy link
Member

spypsy commented Sep 6, 2023 •
edited
Loading

the release-please plugin makes a commit to its open release branch, everytime there's a commit to master.
This commit only updates CHANGELOG.md yet it still triggers a CI pipeline which will re-build packages with an updated changelog.
This shouldn't be necessary since the code should exactly match what's currently on master
@spypsy spypsy added this to A3 Sep 6, 2023
@spypsy spypsy converted this from a draft issue Sep 6, 2023
@spypsy spypsy added this to the 📢 Initial Public Sandbox Release milestone Sep 11, 2023
@spypsy spypsy self-assigned this Sep 11, 2023
@spypsy spypsy moved this from Todo to In Progress in A3 Sep 11, 2023
@spypsy spypsy moved this from In Progress to Todo in A3 Sep 14, 2023
@spypsy spypsy removed their assignment Oct 19, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from the 📢 Initial Public Sandbox Release milestone Oct 27, 2023
@just-mitch just-mitch linked a pull request Jan 12, 2024 that will close this issue
chore: do not run CCI on release-please branches #3984
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

@just-mitch just-mitch

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: do not run CCI on release-please branches AztecProtocol/aztec-packages
3 participants
@spypsy @iAmMichaelConnor @just-mitch