-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StateVariables): Only write if value is changed in public #1742
Comments
There's a slight complication to this one. If in the first 'frame' of a function |
@dbanks12 again relates to circuits and how we are collapsing state changes. |
Disregarding the squishing/collapsing discussed above. The same goal but achieved entirely inside the public state should be possible for the case where we are overwriting a struct but not the entire thing? I think we right now might still be sending multiple write requests even if the values are unchanged? |
I haven't kept up with how public state is being serialised into "write requests" for the kernel to process, or serialised to L1. |
Yes. Which depends on how independent we make sequencing from proving, which depends on performance and costs of the proving system. |
We should only need to perform
write
operations in public if the value is different from the current one. Otherwise we are simply wasting resources.There are multiple variations of this. Differing in how complex they are and the savings they support. Namely at what level we perform the "cleaning".
The overall goal is:
As a note on this, it should also be considered if it is desired to keep posting diffs as now, or posting the public calls (from private -> public) instead.
The text was updated successfully, but these errors were encountered: