Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enabling pubkey check #1720

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 22, 2023

I tried reproducing #1556 issue but it doesn't seem to occur anymore. For this reason the pubkey check can be re-enabled.

Fixes #1556

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@PhilWindle PhilWindle merged commit 5385b18 into master Aug 22, 2023
@PhilWindle PhilWindle deleted the janb/re-enabling-pubkey-check branch August 22, 2023 08:47
codygunton pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

JsonRpcServer does not return a proper class instance but only an object with its properties
2 participants