Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deploying contracts using aztec-cli #1592

Merged
merged 12 commits into from
Aug 17, 2023
Merged

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 16, 2023

Fixes #1591

Note: I've decided to create a separate issue for documenting how to deploy the contracts using aztec.js. I've linked it to the big docs issue.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan marked this pull request as draft August 16, 2023 15:16
@benesjan benesjan force-pushed the janb/deploying-docs branch 2 times, most recently from c8b894a to fdcde2e Compare August 17, 2023 10:44
@benesjan benesjan force-pushed the janb/deploying-docs branch from fdcde2e to 57fd81d Compare August 17, 2023 14:13
@benesjan benesjan changed the title docs: deploying contracts docs: deploying contracts using aztec-cli Aug 17, 2023
@benesjan benesjan marked this pull request as ready for review August 17, 2023 15:39
@benesjan benesjan requested a review from spalladino August 17, 2023 15:39
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But we need to update other guides if we're changing the deploy command.

Tagging @iAmMichaelConnor in case he wants to review as well.

Comment on lines +149 to +150
.argument(
'<abi>',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, but heads up this impacts other guides, as well as the one in the up-dev page. We'll need to update those as well. Let's include them in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe a good argument for writing all code snippets as part of testable code files (like you did earlier this week for some other docs, Santiago), so that the CI can then test that the code snippets are all up-to-date?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I did fail to get them into the CI though (build-system beat me again), but can revisit it next week.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 9dea419

I will send a PR to the sandbox website as well.

docs/docs/dev_docs/contracts/deploying.md Outdated Show resolved Hide resolved
docs/docs/dev_docs/contracts/deploying.md Outdated Show resolved Hide resolved
docs/docs/dev_docs/contracts/deploying.md Outdated Show resolved Hide resolved
docs/docs/dev_docs/contracts/deploying.md Outdated Show resolved Hide resolved
docs/docs/dev_docs/contracts/deploying.md Show resolved Hide resolved
@iAmMichaelConnor
Copy link
Contributor

Tagging @iAmMichaelConnor in case he wants to review as well.

I'm happy with this (and the requested changes) :)

Co-authored-by: Santiago Palladino <[email protected]>
@spalladino spalladino merged commit b43d7a0 into master Aug 17, 2023
@spalladino spalladino deleted the janb/deploying-docs branch August 17, 2023 18:49
codygunton pushed a commit that referenced this pull request Jan 23, 2024
* Initial attempt to have Kebab perform deployments (#1558)

* Initial attempt to have Kebab perform deployments

* Fix e2e tests, don't redeploy if given rollup contract

* Use correct verification key

* Bug fix

* VK fix

* Added curl to Falafel docker image

* WIP

* WIP

* Updated Faucet

* WIP

* Deploy mainnet fork alongside kebab (#1556)

* Deploy mainnet fork alongside kebab

* Added backend block

* Updated kebab TF

Co-authored-by: PhilWindle <[email protected]>

* WIP

* Fixed env var name

* WIP

* Yarn lock files

* Revert explorer and zk-money changes

* Use devnet specific private key

* Additional logging

* Attempt to fix block explorer

* Reverted unnecessary change

* Fix bigint literals and remove hosted sdk e2e test

* Fixes

Co-authored-by: spypsy <[email protected]>

* Fixed command ordering (#1566)

* Fixed scripting (#1567)

* More TF fixes (#1571)

* Force contract redeploy (dev) (#1568)

* force contract redeploy + add port to kebab health check

* undo port specification for healthcheck

* Log the number of drips provided by the faucet (#1518)

* Pw/devnet deployment fixes (#1574)

* Terraform changes to restart Falafel and Faucet on redeployment

* New Devnet chain id

* Fix pkey srs size to (n + 1) while loading a pkey. (#1550)

* Pw/devnet deployment fixes (#1577)

* Terraform changes to restart Falafel and Faucet on redeployment

* New Devnet chain id

* Fixed Falafel Dev Terraform

* Fixed Faucet Dev Terraform (#1578)

* Updated Wasabi Terraform for Dev and Test nets (#1579)

* Fix for Wasabi Uniswap Terraform (#1580)

* update JSON provider request method (#1588)

* update JSON provider request method

* comment clarification

* allow additional methods to go through kebab auth (#1589)

* Allow for setting of Rollup Provider in deployments (#1590)

* Allow for setting of Rollup Provider in deployments

* Force contract redeployment

* Terraform fix

* Pw/testnet deployment (#1591)

* WIP

* WIP

* WIP

* TF updates

* Dev TF fix

Co-authored-by: spypsy <[email protected]>
Co-authored-by: Suyash Bagad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

deploying contracts using aztec-cli
3 participants