fix: align bbmalloc implementations #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
commented
Aug 10, 2023
| @@ -1,8 +1,5 @@ | |||
| #include "aes128.hpp" | |||
|
|
|||
| #define WASM_EXPORT __attribute__((visibility("default"))) | |||
There was a problem hiding this comment.
I cleaned up the places WASM_EXPORT was used while untangling errors. This now takes advantage that 'extern C' is implied by WASM_EXPORT.
ludamad
commented
Aug 10, 2023
| @@ -77,14 +77,6 @@ template <size_t TREE_HEIGHT> void rightfill_with_zeroleaves(std::vector<NT::fr> | |||
|
|
|||
| } // namespace | |||
|
|
|||
| // Note: We don't have a simple way of calling the barretenberg c-bind. | |||
| // Mimic bbmalloc behaviour. | |||
There was a problem hiding this comment.
Laziness on my part initially. Goes back to hackathon. Easy now at least to provide a way to call the function while iterating circuits.
ludamad
changed the title
Rumata888
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was wrong in circuits. This should have never been duplicated (mea culpa). The implementations drifted with the WASI SDK version 20 push.
Don't think we hit issues with this, but they'd be nasty if we did.