Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contract address field to unencrypted logs #1497

Closed
2 tasks done
PhilWindle opened this issue Aug 10, 2023 · 0 comments
Closed
2 tasks done

Add contract address field to unencrypted logs #1497

PhilWindle opened this issue Aug 10, 2023 · 0 comments
Assignees
@benesjan
Milestone
🪵 ABI Encoded Logs

Comments

@PhilWindle
Copy link
Collaborator

PhilWindle commented Aug 10, 2023 •
edited by benesjan
Loading

Unencrypted logs should carry the address of the contract that emitted them. This value will be empty for logs emitted from private functions but correctly populated for public functions.

Tasks
Preview Give feedback
  1. Emit contract address from Noir #2581
  2. Make contract address part of the log hash preimage #2587
@PhilWindle PhilWindle added this to A3 Aug 10, 2023
@PhilWindle PhilWindle converted this from a draft issue Aug 10, 2023
@PhilWindle PhilWindle mentioned this issue Aug 10, 2023
Closed
@alexghr alexghr moved this from Todo to In Progress in A3 Sep 28, 2023
@alexghr alexghr self-assigned this Sep 28, 2023
@alexghr alexghr moved this from In Progress to Todo in A3 Sep 28, 2023
@alexghr alexghr removed their assignment Sep 28, 2023
@benesjan benesjan self-assigned this Sep 28, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Sep 28, 2023
@benesjan benesjan added this to the 🪵 ABI Encoded Logs milestone Sep 29, 2023
@benesjan benesjan moved this from In Progress to In Review in A3 Oct 2, 2023
@PhilWindle PhilWindle moved this from In Review to Done in A3 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
🪵 ABI Encoded Logs
Development

No branches or pull requests
4 participants
@alexghr @benesjan @rahul-kothari @PhilWindle