chore: update pull request template #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hopefully fits our current work better
spalladino
approved these changes
Aug 2, 2023
.github/pull_request_template.md
Outdated
| - [ ] The branch has been merged or rebased against the head of its merge target. | ||
| - [ ] I'm happy for the PR to be merged at the reviewer's next convenience. | ||
| - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). | ||
| - [ ] The branch is up-to-date (i.e. no Update Branch button). |
There was a problem hiding this comment.
Feel like this one doesn't make much sense, since it can be completed once you get the PR ready, but can fall out of date pretty quickly. But I'm fine keeping it for historic reasons.
|
I've removed that line. Let's chock it up to 'common git sense' and see how that fares. If someone doesn't know the reviewer can always hit Update Branch, so it should be fine. |
|
Another tweak to optimize for commit messages (removed description heading) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fits our current work better.