Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: throw when creating an instance of non-existent contract #1300

Merged
merged 10 commits into from
Aug 1, 2023
Merged

feat: throw when creating an instance of non-existent contract #1300

merged 10 commits into from
Aug 1, 2023

Conversation

benesjan
Copy link
Contributor

Description

Fixes #1225

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft July 31, 2023 13:23
@benesjan benesjan force-pushed the janb/non-existent-contract-check-in-ts-wrapper branch 3 times, most recently from 1ec0373 to 1cab797 Compare August 1, 2023 08:17
@benesjan benesjan force-pushed the janb/non-existent-contract-check-in-ts-wrapper branch from 8da2336 to a3b3009 Compare August 1, 2023 13:51
@benesjan benesjan marked this pull request as ready for review August 1, 2023 15:05
@benesjan benesjan enabled auto-merge (squash) August 1, 2023 15:06
@benesjan benesjan merged commit 5353ed0 into master Aug 1, 2023
@benesjan benesjan deleted the janb/non-existent-contract-check-in-ts-wrapper branch August 1, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw an error if contract doesn't exist in a contract tree when creating an instance
2 participants
@benesjan @PhilWindle