refactor: contact --> sender in PXE API
#10861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
12-18-refactor_pxe.registercontact_--_pxe.registersender
branch
from
20d9273 to
f18e38a
Compare
benesjan
changed the title
contact --> sender in PXE API
Docs PreviewHey there! 👋 You can check your preview at https://676464315779431724fedcd4--aztec-docs-dev.netlify.app |
|
Pasted from slack: registerCounterparty? registerConnection? registerFriend? registerPerson? registerSomeone? |
rahul-kothari
approved these changes
Dec 19, 2024
docs/docs/migration_notes.md
Outdated
| @@ -6,6 +6,21 @@ keywords: [sandbox, aztec, notes, migration, updating, upgrading] | |||
|
|
|||
| Aztec is in full-speed development. Literally every version breaks compatibility with the previous ones. This page attempts to target errors and difficulties you might encounter when upgrading, and how to resolve them. | |||
|
|
|||
| ## TBD | |||
There was a problem hiding this comment.
can you merge with master and include these in the 0.68.0 section? 🙏
benesjan
force-pushed
the
12-18-refactor_pxe.registercontact_--_pxe.registersender
branch
from
f18e38a to
c40ee3a
Compare
benesjan
deleted the
12-18-refactor_pxe.registercontact_--_pxe.registersender
branch
TomAFrench
added a commit
that referenced
this pull request
Dec 20, 2024
* master: (119 commits) chore(master): Release 0.68.0 (#10834) feat: enable profiling with local PXE in cli-wallet (#10736) chore: values for sepolia deployment (#10362) fix: vm_full_tests.yml (#10912) chore: disable bb-sanitizers.yml (#10901) chore: Check yarn version during bootstrap (#10910) fix(p2p): default peer score penalties (#10896) feat: Updated metrics (#10885) feat: Reduce bundle sizes, remove polyfills (#10877) chore: Replace bbup.dev link (#10908) chore(avm): extra column information in lookups (#10905) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore: disable flake in e2e_fees/private_payments (#10898) chore(ci): disable e2e_cheat_codes.test.ts (#10897) fix: increase default heartbeat (#10891) fix(p2p): less verbose error (#10886) refactor: `contact` --> `sender` in PXE API (#10861) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerContacthas been deemed confusing because the name is too similar toregisterContract.For this reason we've decided to rename it.