Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a flag to disable fee payment checks in AVM simulator #10852

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

sirasistant
Copy link
Collaborator

@sirasistant sirasistant commented Dec 18, 2024

Resolves #10833
This is a simulator only change, since the AVM circuit should keep failing if the balance is not enough.

@sirasistant sirasistant added the e2e-all CI: Enables this CI job. label Dec 19, 2024
@sirasistant sirasistant changed the title feat: Add a flag to disable fee payment checks (WIP) feat: Add a flag to disable fee payment checks Dec 19, 2024
@sirasistant sirasistant changed the title feat: Add a flag to disable fee payment checks feat: Add a flag to disable fee payment checks in AVM Dec 19, 2024
@sirasistant sirasistant changed the title feat: Add a flag to disable fee payment checks in AVM feat: Add a flag to disable fee payment checks in AVM simulator Dec 19, 2024
Copy link
Collaborator

@LeilaWang LeilaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@sirasistant sirasistant merged commit 41407ce into master Dec 19, 2024
77 checks passed
@sirasistant sirasistant deleted the arv/mock_fee_payment branch December 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flag to mock fee payer balance read to complete the simulation and get the estimated fee.
2 participants