chore: 24 second epochs in CI #10646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-mitch
force-pushed
the
10644-chore-make-kind-tests-faster-in-normal-ci
branch
from
f65635e to
761a5ea
Compare
just-mitch
force-pushed
the
10644-chore-make-kind-tests-faster-in-normal-ci
branch
from
761a5ea to
262f621
Compare
just-mitch
commented
Dec 18, 2024
| // This is in place to ensure that we don't have a bad regression in the network | ||
| const maxMissedSlots = Math.floor(Number(epochDuration) * MAX_MISSED_SLOT_PERCENT); | ||
| expect(missedSlots).toBeLessThanOrEqual(maxMissedSlots); | ||
| expect(newTips.pending).toBeGreaterThan(controlTips.pending); |
There was a problem hiding this comment.
When we have short epochs (e.g. 4), its very reasonable for us to only have 1 block get produced: the nodes that restart could be proposers for all 4 blocks, and it could take about a minute for them to come back online after the restart.
Maddiaa0
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests in CI now sub 30 minutes.
Locally I'm running 4epochs in 13 minutes, and reorg test in 20 minutes.