Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Kernel matches read requests to pending commitments #1063

Closed
Tracked by #512
dbanks12 opened this issue Jul 14, 2023 · 2 comments
Closed
Tracked by #512

[C++] Kernel matches read requests to pending commitments #1063

dbanks12 opened this issue Jul 14, 2023 · 2 comments
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@dbanks12
Copy link
Collaborator

Blocked by #906
@dbanks12 dbanks12 added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Jul 14, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 14, 2023
@dbanks12 dbanks12 mentioned this issue Jul 14, 2023
Closed
@jeanmon
Copy link
Contributor

jeanmon commented Jul 14, 2023

PR #907 provides matching (without hints) in the ordering circuit and even makes the chopping for every read (which is clearly wrong as we should do that only when corresponding nullifiers are present.)

@jeanmon jeanmon mentioned this issue Jul 14, 2023
Merged
6 tasks
@jeanmon jeanmon moved this from Todo to In Progress in A3 Jul 14, 2023
@jeanmon jeanmon moved this from In Progress to In Review in A3 Jul 14, 2023
@dbanks12
Copy link
Collaborator Author

Done in #907

@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jul 14, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbanks12 @jeanmon