Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit generated variants of protocol circuits to git and enforce consistency #10278

Open
TomAFrench opened this issue Nov 28, 2024 · 4 comments
Open

Commit generated variants of protocol circuits to git and enforce consistency #10278

TomAFrench opened this issue Nov 28, 2024 · 4 comments
Assignees
@aakoshh

Comments

@TomAFrench
Copy link
Member

Currently there's no Nargo.toml file for the protocol circuits which prevents these tests being run from inside of the noir repository. We should commit these to git and add a CI task which checks to make sure that these match the output from generate_variants.js.
@TomAFrench
Copy link
Member Author

https://github.com/AztecProtocol/aztec-packages/blob/master/noir-projects/noir-protocol-circuits/scripts/generate_variants.js

@TomAFrench TomAFrench mentioned this issue Nov 28, 2024
Closed
@TomAFrench
Copy link
Member Author

TomAFrench commented Nov 29, 2024 •
edited
Loading

Actually, @sirasistant can you take a look at this? Should be super quick but a big help for us.

@sirasistant
Copy link
Collaborator

Sure, let me see

@sirasistant sirasistant mentioned this issue Nov 29, 2024
Closed
@sirasistant
Copy link
Collaborator

Should we close due to #10313 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aakoshh aakoshh

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aakoshh @sirasistant @TomAFrench