Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silo the first field of public logs #10273

Open
nventuro opened this issue Nov 28, 2024 · 0 comments
Open

Silo the first field of public logs #10273

nventuro opened this issue Nov 28, 2024 · 0 comments
Labels
C-avm Component: AVM related tickets (aka public VM) C-aztec.nr Component: Aztec smart contract framework team-bonobos

Comments

@nventuro
Copy link
Contributor

#10210 introduced siloing of the first field of private logs by having the private kernel hash it with the contract address. This is a very powerful primitive, as it cheaply lets contracts verify that a given log was indeed emitted by a certain contract, and so we can safely process them in order to do note discovery, message processing, etc.

However, this does not currently happen for logs emitted in public. encrypted_logs/payload.nr was modified to make partial note logs computed in private (which are only emitted in public) manually perform said siloing in the app, behaving as if the AVM was doing it. Even though we don't really need for public logs to have said siloing since they're public already and can be verified via alternative means, it'd be better if all logs looked the same, particularly when it comes to message delivery via tags (#9373) as not having this would mean we'd need to deal with multiple tagging schemes.

@nventuro nventuro added C-avm Component: AVM related tickets (aka public VM) C-aztec.nr Component: Aztec smart contract framework team-bonobos labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-avm Component: AVM related tickets (aka public VM) C-aztec.nr Component: Aztec smart contract framework team-bonobos
Projects
None yet
Development

No branches or pull requests

1 participant