Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update fee payouts #10063

Closed
LHerskind opened this issue Nov 20, 2024 · 0 comments · Fixed by #10231
Closed

feat: update fee payouts #10063

LHerskind opened this issue Nov 20, 2024 · 0 comments · Fixed by #10231
Assignees
Labels
C-l1-contracts Component: contracts deployed to L1

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Nov 20, 2024

Currently all fees are paid out, the congestion components should be burned to protect against sequencers inflating fees to boost their own profits.

Logically, this is really simple to implement with the data from #9962 and #9716 as it will be total mana used * congestion cost per mana. However, we have an issue as this is only deal with at the time of the proof being submitted where we do not provide the full header etc.

Namely, the congestion_cost_per_mana is something we are keeping track of "live" as it is happening, so we have the value available when we are submitting a block proposal. We could compute the value for that point in time, but that might not be worth the cost etc.

In the short term, I think it might be fine to store it, and then we will need to deal with the costs when are getting to #9826 where we will likely go to storing hash for the BlockLog, making is cheaper for us to include some of these "temp" values in there.

This way we have the values needed easily available.

@LHerskind LHerskind added the C-l1-contracts Component: contracts deployed to L1 label Nov 20, 2024
@LHerskind LHerskind self-assigned this Nov 20, 2024
@LHerskind LHerskind linked a pull request Nov 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-l1-contracts Component: contracts deployed to L1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant