Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blobs): remove tx effects from propose calldata #10058

Open
Maddiaa0 opened this issue Nov 20, 2024 · 0 comments
Open

feat(blobs): remove tx effects from propose calldata #10058

Maddiaa0 opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
C-l1-contracts Component: contracts deployed to L1 C-node Component: Aztec Node team-alpha

Comments

@Maddiaa0
Copy link
Member

Overview

This is the final bit of work to remove our dependence on calldata.

/**

  • @notice Publishes the body and propose the block
  • @dev eth_log_handlers rely on this function
  • @param _header - The L2 block header
  • @param _archive - A root of the archive tree after the L2 block is applied
  • @param _blockHash - The poseidon2 hash of the header added to the archive tree in the rollup circuit
  • @param _signatures - Signatures from the validators
  • // TODO(feat(blobs): Integrate beacon chain client/web2 blob getter #9101): The below _body should be removed once we can extract blobs. It's only here so the archiver can extract tx effects.
  • @param _body - The body of the L2 block
  • @param _blobInput - The blob evaluation KZG proof, challenge, and opening required for the precompile.
    */
    function proposeAndClaim(
    bytes calldata _header,
    bytes32 _archive,
    bytes32 _blockHash,
    bytes32[] memory _txHashes,
    SignatureLib.Signature[] memory _signatures,
  • bytes calldata _body,
    bytes calldata _blobInput,
    EpochProofQuoteLib.SignedEpochProofQuote calldata _quote
    ) external override(IRollup) {
    propose(_header, _archive, _blockHash, _txHashes, _signatures, _body, _blobInput);
    claimEpochProofRight(_quote);
    }
    Remove body from the propose calldata, the nodes should continue running smoothly even though calldata requesting has been removed.

Relevant Links

Part of larger meta issue #9101 (comment)

See engineering designs document: AztecProtocol/engineering-designs#41

@Maddiaa0 Maddiaa0 added C-node Component: Aztec Node C-l1-contracts Component: contracts deployed to L1 team-alpha labels Nov 20, 2024
@Maddiaa0 Maddiaa0 self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-l1-contracts Component: contracts deployed to L1 C-node Component: Aztec Node team-alpha
Projects
None yet
Development

No branches or pull requests

1 participant