From c999dae76580ea63486aaa17edb774736dc32b89 Mon Sep 17 00:00:00 2001 From: ludamad Date: Fri, 19 Apr 2024 11:10:36 -0400 Subject: [PATCH] fix: merge-check (#5873) This was passing on skip. We may have to improve this logic in the future. Note: This wasn't done in github checks page because it can't list matrix builds. --- .github/workflows/ci.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1b5547c9488..b3902c551f2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -147,8 +147,17 @@ jobs: merge-check: runs-on: ${{ github.actor }}-x86 needs: [e2e, bb-native-tests, bb-bench] + if: always() # Ensures this job runs regardless of the success or failure of dependencies. steps: - - run: echo Pull request merging now allowed. + - run: | + echo "E2E Test Status: ${{ needs.e2e.result }}" + echo "Native Tests Status: ${{ needs.bb-native-tests.result }}" + echo "Bench Tests Status: ${{ needs.bb-bench.result }}" + if [[ "${{ needs.e2e.result }}" != 'success' || "${{ needs.bb-native-tests.result }}" != 'success' || "${{ needs.bb-bench.result }}" != 'success' ]]; then + echo "Pull request merging not allowed due to failures." + exit 1 + fi + echo "Pull request merging now allowed." notify: needs: [e2e, bb-native-tests, bb-bench]