From 7eec1f8244970d110424507736e6faa18035398f Mon Sep 17 00:00:00 2001 From: benesjan Date: Tue, 2 Jan 2024 13:16:57 +0000 Subject: [PATCH] comments --- noir/aztec_macros/src/lib.rs | 1 + .../noir-contracts/src/contracts/test_contract/src/main.nr | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/noir/aztec_macros/src/lib.rs b/noir/aztec_macros/src/lib.rs index 4b1ef36b7046..2dd083a9b118 100644 --- a/noir/aztec_macros/src/lib.rs +++ b/noir/aztec_macros/src/lib.rs @@ -504,6 +504,7 @@ fn generate_selector_impl(structure: &NoirStruct) -> TypeImpl { )))]); // Define `FunctionSelector` return type + // TODO(https://github.com/AztecProtocol/aztec-packages/issues/3590): Make this point to aztec-nr once the relevant issue is fixed. let return_type_path = chained_path!("protocol_types", "abis", "function_selector", "FunctionSelector"); let return_type = FunctionReturnType::Ty(make_type(UnresolvedTypeData::Named(return_type_path, vec![]))); diff --git a/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr b/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr index 52710385844f..ed5a753c26b8 100644 --- a/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr +++ b/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr @@ -6,6 +6,10 @@ contract Test { AztecAddress, EthAddress, }; + // The following import is here in order to make the event macro work because the macro doesn't add the import. + // It doesn't add the import because in the future we will re-export all the types via aztec-nr and aztec-nr is + // already auto-imported by the macros. + // TODO(https://github.com/AztecProtocol/aztec-packages/issues/3590): Remove this once the issue is fixed. use dep::protocol_types; // docs:start:unencrypted_import use dep::aztec::log::emit_unencrypted_log;