diff --git a/barretenberg/cpp/src/barretenberg/flavor/flavor.hpp b/barretenberg/cpp/src/barretenberg/flavor/flavor.hpp index 0ea704d2eda..67c20814a34 100644 --- a/barretenberg/cpp/src/barretenberg/flavor/flavor.hpp +++ b/barretenberg/cpp/src/barretenberg/flavor/flavor.hpp @@ -356,15 +356,9 @@ namespace bb { template concept IsPlonkFlavor = IsAnyOf; -template -concept IsUltraPlonkFlavor = IsAnyOf; - template concept IsUltraPlonkOrHonk = IsAnyOf; -template -concept IsHonkFlavor = IsAnyOf; - template concept IsUltraFlavor = IsAnyOf; @@ -400,7 +394,6 @@ AvmRecursiveFlavor_>; template concept IsECCVMRecursiveFlavor = IsAnyOf>; -template concept IsGrumpkinFlavor = IsAnyOf; template concept IsFoldingFlavor = IsAnyOf compute_permutation_mapping( const auto num_public_inputs = static_cast(circuit_constructor.public_inputs.size()); size_t pub_inputs_offset = 0; - if constexpr (IsHonkFlavor) { + if constexpr (IsUltraFlavor) { pub_inputs_offset = proving_key->pub_inputs_offset; } for (size_t i = 0; i < num_public_inputs; ++i) { @@ -374,7 +374,7 @@ void compute_permutation_argument_polynomials(const typename Flavor::CircuitBuil typename Flavor::ProvingKey* key, const std::vector& copy_cycles) { - constexpr bool generalized = IsUltraPlonkFlavor || IsUltraFlavor; + constexpr bool generalized = IsUltraPlonkOrHonk; auto mapping = compute_permutation_mapping(circuit, key, copy_cycles); if constexpr (IsPlonkFlavor) { // any Plonk flavor diff --git a/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/decider_recursive_verifier.cpp b/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/decider_recursive_verifier.cpp index 8e9a4cb4998..162a890e5ff 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/decider_recursive_verifier.cpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/decider_recursive_verifier.cpp @@ -45,9 +45,7 @@ std::array DeciderRecursiveVerifier_:: return pairing_points; } -template class DeciderRecursiveVerifier_>; template class DeciderRecursiveVerifier_>; -template class DeciderRecursiveVerifier_>; template class DeciderRecursiveVerifier_>; template class DeciderRecursiveVerifier_>; template class DeciderRecursiveVerifier_>; diff --git a/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.cpp b/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.cpp index 44b27f74bb5..0dc60e9438f 100644 --- a/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.cpp +++ b/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.cpp @@ -37,7 +37,7 @@ void TraceToPolynomials::populate(Builder& builder, // data auto trace_data = construct_trace_data(builder, proving_key, is_structured); - if constexpr (IsHonkFlavor) { + if constexpr (IsUltraFlavor) { proving_key.pub_inputs_offset = trace_data.pub_inputs_offset; } if constexpr (IsUltraPlonkOrHonk) { @@ -101,7 +101,7 @@ typename TraceToPolynomials::TraceData TraceToPolynomials::const auto block_size = static_cast(block.size()); // Save ranges over which the blocks are "active" for use in structured commitments - if constexpr (IsHonkFlavor) { + if constexpr (IsUltraFlavor) { if (block.size() > 0) { proving_key.active_block_ranges.emplace_back(offset, offset + block.size()); } diff --git a/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.hpp b/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.hpp index 43f268f8c51..46dc4dbb9a2 100644 --- a/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.hpp +++ b/barretenberg/cpp/src/barretenberg/trace_to_polynomials/trace_to_polynomials.hpp @@ -31,7 +31,7 @@ template class TraceToPolynomials { PROFILE_THIS_NAME("TraceData constructor"); - if constexpr (IsHonkFlavor) { + if constexpr (IsUltraFlavor) { // Initialize and share the wire and selector polynomials for (auto [wire, other_wire] : zip_view(wires, proving_key.polynomials.get_wires())) { wire = other_wire.share(); diff --git a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.cpp b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.cpp index 4b3531428af..93a00d5c37c 100644 --- a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.cpp +++ b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.cpp @@ -11,7 +11,7 @@ namespace bb { * @tparam Flavor * @param circuit */ -template size_t DeciderProvingKey_::compute_dyadic_size(Circuit& circuit) +template size_t DeciderProvingKey_::compute_dyadic_size(Circuit& circuit) { // for the lookup argument the circuit size must be at least as large as the sum of all tables used const size_t min_size_due_to_lookups = circuit.get_tables_size(); @@ -37,7 +37,7 @@ template size_t DeciderProvingKey_::compute_dyadic * @tparam Flavor * @param circuit */ -template +template void DeciderProvingKey_::construct_databus_polynomials(Circuit& circuit) requires IsMegaFlavor { @@ -96,7 +96,7 @@ void DeciderProvingKey_::construct_databus_polynomials(Circuit& circuit) * @tparam Flavor * @param circuit */ -template +template void DeciderProvingKey_::move_structured_trace_overflow_to_overflow_block(Circuit& circuit) { auto& blocks = circuit.blocks; diff --git a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp index e3f2c6a3a63..77cabf182d9 100644 --- a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp +++ b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp @@ -20,7 +20,7 @@ namespace bb { * @details This is the equivalent of ω in the paper. */ -template class DeciderProvingKey_ { +template class DeciderProvingKey_ { using Circuit = typename Flavor::CircuitBuilder; using ProvingKey = typename Flavor::ProvingKey; using VerificationKey = typename Flavor::VerificationKey; @@ -186,7 +186,7 @@ template class DeciderProvingKey_ { ASSERT(dyadic_circuit_size > max_tables_size); // Allocate the table polynomials - if constexpr (IsHonkFlavor) { + if constexpr (IsUltraFlavor) { for (auto& poly : proving_key.polynomials.get_tables()) { poly = typename Flavor::Polynomial(max_tables_size, dyadic_circuit_size, table_offset); }