From 0a6647d8db263699332adecd611bd694f2301be2 Mon Sep 17 00:00:00 2001 From: LHerskind Date: Thu, 6 Jun 2024 15:10:32 +0000 Subject: [PATCH] update comments --- noir-projects/aztec-nr/aztec/src/context/private_context.nr | 5 +---- .../simulator/src/client/client_execution_context.ts | 4 +++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/noir-projects/aztec-nr/aztec/src/context/private_context.nr b/noir-projects/aztec-nr/aztec/src/context/private_context.nr index e04db909dfd..25570b7c9de 100644 --- a/noir-projects/aztec-nr/aztec/src/context/private_context.nr +++ b/noir-projects/aztec-nr/aztec/src/context/private_context.nr @@ -1,6 +1,3 @@ -// By updating the import here, you can "switch" between using an oracle for computing the encrypted -// logs, or constraining it in the circuit. The interfaces are the exact same, so just flip this. -// use crate::oracle::logs::compute_encrypted_log; use crate::encrypted_logs::{payload::compute_encrypted_note_log}; use crate::{ @@ -325,7 +322,7 @@ impl PrivateContext { ) where [Field; N]: LensForEncryptedLog { let ovsk_app = self.request_ovsk_app(ovpk_m.hash()); - // We are currently just encrypting it EXACTLY the same way as if it was a note. + // We are currently just encrypting it unconstrained, but otherwise the same way as if it was a note. let counter = self.next_counter(); let encrypted_log: [u8; M] = compute_encrypted_log( contract_address, diff --git a/yarn-project/simulator/src/client/client_execution_context.ts b/yarn-project/simulator/src/client/client_execution_context.ts index 0e1381d782b..1309dc26323 100644 --- a/yarn-project/simulator/src/client/client_execution_context.ts +++ b/yarn-project/simulator/src/client/client_execution_context.ts @@ -383,7 +383,9 @@ export class ClientExecutionContext extends ViewDataOracle { const ephSk = GrumpkinScalar.random(); - // @todo Needs to be populated + // @todo This should be populated properly. + // Note that this encryption function SHOULD not be used, but is currently used + // as oracle for encrypted event logs. const recipient = AztecAddress.random(); return taggedNote.encrypt(ephSk, recipient, ivpkM, ovKeys);