Merge cockroachdb#68396

68396: sql: fix pg_default_acl comment r=RichardJCai a=rafiss Release note: None Co-authored-by: Rafi Shamim <[email protected]>
Azhng · Aug 3, 2021 · 9f15510 · 9f15510
2 parents 6115e79 + 3896e4b
commit 9f15510
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/sql/logictest/testdata/logic_test/pg_catalog b/pkg/sql/logictest/testdata/logic_test/pg_catalog
@@ -3635,7 +3635,7 @@ objoid      classoid    objsubid  description
 4294967133  4294967138  0         pg_cursors was created for compatibility and is currently unimplemented
 4294967132  4294967138  0         available databases (incomplete)
 4294967131  4294967138  0         pg_db_role_setting was created for compatibility and is currently unimplemented
-4294967130  4294967138  0         default ACLs (empty - unimplemented)
+4294967130  4294967138  0         default ACLs; these are the privileges that will be assigned to newly created objects
 4294967129  4294967138  0         dependency relationships (incomplete)
 4294967128  4294967138  0         object comments
 4294967127  4294967138  0         enum types and labels (empty - feature does not exist)

diff --git a/pkg/sql/pg_catalog.go b/pkg/sql/pg_catalog.go
@@ -1110,8 +1110,8 @@ https://www.postgresql.org/docs/9.5/catalog-pg-database.html`,
 }
 
 var pgCatalogDefaultACLTable = virtualSchemaTable{
-	comment: `default ACLs (empty - unimplemented)
-https://www.postgresql.org/docs/9.6/catalog-pg-default-acl.html`,
+	comment: `default ACLs; these are the privileges that will be assigned to newly created objects
+https://www.postgresql.org/docs/13/catalog-pg-default-acl.html`,
 	schema: vtable.PGCatalogDefaultACL,
 	populate: func(ctx context.Context, p *planner, dbContext catalog.DatabaseDescriptor, addRow func(...tree.Datum) error) error {
 		h := makeOidHasher()