Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Suggestion ] Add rollForward policy to the global.json config #4259

Closed
FoggyFinder opened this issue Jul 10, 2020 · 6 comments
Closed

[ Suggestion ] Add rollForward policy to the global.json config #4259

FoggyFinder opened this issue Jul 10, 2020 · 6 comments

Comments

@FoggyFinder
Copy link
Contributor

https://docs.microsoft.com/en-us/dotnet/core/tools/global-json?tabs=netcore3x#rollforward

@kekekeks
Copy link
Member

kekekeks commented Jul 10, 2020

We have SDK version pinned because the concept of backwards compatibility seems to not apply well to the SDK. Anything newer than one in our global.json complains about a missing method in XmlSerializer

@FoggyFinder
Copy link
Contributor Author

Anything newer than one in our global.json complains about a missing method in XmlSerializer

Are you sure ? I have only 3.1.301 so I add rollForward locally every time: without it most projects from solution are unloaded and except #4257 (which seems unrelated) I haven't saw any other issues.

@grokys
Copy link
Member

grokys commented Jul 10, 2020

The very next patch version after 3.1.101 (3.1.201 I think) broke Avalonia builds (see SharpGenTools/SharpGenTools#164 (comment)). This wouldn't be the first time that a .NET update broke our CI builds, so I think not having a roll-forward policy was a good idea.

@FoggyFinder
Copy link
Contributor Author

Okay. Closing the issue then.
Though I personally think it would be better to find the actual reason and fix it ;-)

@kekekeks
Copy link
Member

The actual reason is most likely a bug in CoreCLR

@Kryptos-FR
Copy link
Contributor

Kryptos-FR commented Aug 31, 2020

I have the latest version of VS 2019 and VS 2019 preview (both with .NET Core 2.1 and 3.1 installed) and if I don't remove the specific version from global.json, not a single project can be loaded.

edit: currently building and running with 3.1.401 without any issue (after adding "rollForward": "latestFeature").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants