Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Update close block button selector #95592

Merged
merged 3 commits into from
Oct 23, 2024
Merged

E2E: Update close block button selector #95592

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb77cb3
Update close block button label
holdercp Oct 22, 2024
87e9ef8
Match both the current label and the new one
holdercp Oct 22, 2024
dc9dbc2
Add comment to clarify new selector
holdercp Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/calypso-e2e/src/lib/components/editor-sidebar-block-inserter-component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ import { EditorComponent } from './editor-component';

const sidebarParentSelector = '.block-editor-inserter__main-area';
const selectors = {
closeBlockInserterButton: 'button[aria-label="Close block inserter"]',
// This selector was updated to the capitalized label in Gutenberg v19.5.0. Once that is released, we should be able to remove the old selector ("Close block inserter").
// See: https://github.com/WordPress/gutenberg/pull/65983
closeBlockInserterButton:
'button[aria-label="Close Block Inserter"], button[aria-label="Close block inserter"]',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming once GB 19.5.0 is released, we won't need the old selector?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure as well. Maybe it's worth adding a comment?

blockSearchInput: `${ sidebarParentSelector } input[type="search"]`,
patternResultItem: ( name: string ) => `${ sidebarParentSelector } div[aria-label="${ name }"]`,
};
Expand Down
Loading