Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Fix failing tests on Gutenberg RC #95519

Merged
merged 1 commit into from
Oct 21, 2024
Merged

E2E: Fix failing tests on Gutenberg RC #95519

merged 1 commit into from
Oct 21, 2024

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Oct 18, 2024

Related to p1729177519243639-slack-CBTN58FTJ

Proposed Changes

Testing Instructions

  • Set up your test env using this guide.
  • To run the test on the edge GB version, get the failing test paths listed here and run GUTENBERG_EDGE=true yarn workspace wp-e2e-tests test -- [test path]. These may be easier ways to run the suite, which I don't know about.
  • The PR E2E tests should be passing.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@m1r0 m1r0 marked this pull request as ready for review October 18, 2024 15:05
@m1r0 m1r0 self-assigned this Oct 18, 2024
@m1r0 m1r0 added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Oct 18, 2024
Copy link
Contributor

@holdercp holdercp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the tests caused some flakiness but they passed in CI.

@holdercp holdercp merged commit b090fe6 into trunk Oct 21, 2024
19 checks passed
@holdercp holdercp deleted the fix/e2e-tests-gb-rc branch October 21, 2024 16:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
@m1r0
Copy link
Member Author

m1r0 commented Oct 22, 2024

Thanks for the review @holdercp!

FYI, I've just noticed that this PR is not fixing the mobile tests.

@holdercp
Copy link
Contributor

@m1r0 I saw that this morning. I've fixed them in this PR. If you have the time, I'd love a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants