-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Editor: adds autosave parameter to outbound queries #19261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lint error on adding to the var
.
Noting that I raised UX implications of not distinguishing between autosaves and intentional saves (seamless interactions for users).
That said, this works as advertised. With lint issue, might consider only adding to the query if the autosave option is explicitly true. Don't know that we need to be passing autosave=false
for every save if this is inferred as the default from the REST API end.
Thanks for taking a look!
Good call!
With Activity Log, we simply plan on not showing autosave activities in their logs. This behavior is already present when someone creates a post in wp-admin. Can you elaborate on your concerns a bit? Do you forsee any negative side-effects? |
It's not as much a technical concern as much as it is: There seems to be some general UX desire toward users not ever needing to explicitly press a Save button, and if this were the case there would be no activity log entries whatsoever for drafts. |
753bd74
to
c7e1f1c
Compare
When the post editor decides to save automatically, add an autosave parameter to the API query. This allows the server to differentiate between autosaves, and manual saves.
c7e1f1c
to
a3a0b8d
Compare
@aduth - i fixed the lint errors, and addressed your feedback. |
When the post editor decides to save automatically, add an autosave parameter to
the API query.
This allows the server to differentiate between autosaves, and manual saves, and cleans out unnecessary noise the Activity Log.