WP 6.4 + Gutenberg are causing critical errors when editing posts on Atomic sites

[inaikem]

Quick summary

WP 6.4 + Gutenberg are causing critical errors on Atomic sites.

CLI errors:

PHP Fatal error:  Uncaught TypeError: array_merge(): Argument #1 must be of type array, null given in /wordpress/plugins/gutenberg/16.9.0/lib/experimental/fonts-api/class-wp-fonts-resolver.php:208
Stack trace:
#0 /wordpress/plugins/gutenberg/16.9.0/lib/experimental/fonts-api/class-wp-fonts-resolver.php(208): array_merge(NULL, Array)
#1 /wordpress/plugins/gutenberg/16.9.0/lib/experimental/fonts-api/class-wp-fonts-resolver.php(117): WP_Fonts_Resolver::get_settings()
#2 /wordpress/core/6.4/wp-includes/class-wp-hook.php(324): WP_Fonts_Resolver::register_fonts_from_theme_json('')
#3 /wordpress/core/6.4/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)
#4 /wordpress/core/6.4/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#5 /wordpress/core/6.4/wp-settings.php(643): do_action('init')
#6 /srv/htdocs/wp-config.php(83): require_once('/wordpress/core...')
#7 /wordpress/core/6.4/wp-load.php(55): require_once('/srv/htdocs/wp-...')
#8 /wordpress/core/6.4/wp-blog-header.php(13): require_once('/wordpress/core...')
#9 /wordpress/core/6.4/index.php(17): require('/wordpress/core...')
#10 {main}
  thrown in /wordpress/plugins/gutenberg/16.9.0/lib/experimental/fonts-api/class-wp-fonts-resolver.php on line 208

Steps to reproduce

1. Have an Atomic site running WP 6.4 with Gutenberg 16.9 active.
2. Edit a post using the Block Editor.
3. You will see a critical error.
4. Check CLI for PHP errors.
5. Deactivate Gutenberg 16.9 - issue resolved.

What you expected to happen

No critical error.

What actually happened

A critical error appeared

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

Deactivate Gutenberg 16.9 and Classic Editor via CLI.

Related interactions:
7275665-zd-a8c
7275723-zd-a8c
7275932-zd-a8c

[inaikem]

@liviopv and @Automattic/reactor for visibiltiy

[github-actions]

Support References

This comment is automatically generated. Please do not edit it.

• 7275665-zen
• 7275723-zen
• 7275932-zen
• 7276097-zen
• 7276186-zen
• 7276200-zen
• 7276323-zen
• 7276361-zen
• 7276689-zen
• 7276747-zen
• 7276935-zen
• 7276989-zen
• 7276965-zen
• 7277140-zen
• 7277204-zen
• 7277667-zen
• 7277652-zen
• 7277723-zen
• 7277750-zen
• 7277779-zen
• 7277895-zen
• 7277884-zen
• 7277615-zen
• 7277812-zen
• 7277868-zen
• 7281931-zen
• 7298279-zen
• 7298788-zen
• 7298700-zen
• 7299000-zen
• 7298724-zen
• 7300077-zen
• 7275307-zen
• 7299976-zen
• 7300006-zen
• 7302373-zen
• 7275248-zen
• 7302626-zen
• 7298210-zen
• 7298251-zen
• 7304193-zen
• 7306675-zen
• 7307909-zen
• 7318641-zen
• 7318070-zen
• 7322181-zen
• 7268530-zen

[Greatdane]

7276097-zd-a8c

[rambogenius]

• 7276186-zen

[druesome]

7276200-zen

[rambogenius]

• 7276323-zen

[edwinho89]

7276361-zd-a8c

[jorpdesigns]

7276689-zen

[dragstor]

7276747-zen

ℹ️ Downgrading PHP to 7.4 seems to be fixing this somehow, for what it matters 🤔

[i11za]

7276935-zd-a8c

[liviopv]

Switching Priority to Blocker due to support impact.

There's likely another component in the steps to reproduce that we're not seeing yet. I wasn't able to replicate it on https://atlivio.wpcomstaging.com/ with GB 16.9.

What I tried:

• Publish posts and pages
• Edit posts and pages
• Switch themes (TT3 > Fewer)
• Changing fonts to a font loaded from the Jetpack Google Fonts module both from Global Styles and Block Inspector

[liviopv]

More testing:

• Switched to a classic theme - no change
• Turned on Classic Editor - no change
• When Classic Editor is active, but Block Editor is default, the block toolbar looks chunkier than usual
  

[simison]

When Classic Editor is active, but Block Editor is default, the block toolbar looks chunkier than usual

cc @Automattic/team-calypso-components

[rosepajaroja]

7276989-zd-a8c

Another one. Also noting that navigation to Feedback and Jetpack dashboard are also affected.

Deactivated Gutenberg for now.

[retnonindya]

@rosepajaroja about this one: 7276965-zen -- I wonder if I missed anything. I don't see the user has AT site and the issue is on coupon code.

[retnonindya]

Sharing this on GH in case important:

I wonder if this is theme-specific considering how the issue seems intermittent. After looking at the tickets, these are the themes that the reports have:

• Pendant
• Twenty Twenty Two
• Course (third-party, but developed by A8C)
• Partdo Child (third-party)
• Hello Elementor (third-party)

For Hello Elementor, I can access the editor, so there might be something else. Other than Hello Elementor and Partdo Child (I didn’t install/activate Partdo Child on my site since it seems like a paid premium third-party theme from ThemeForest/third-party marketplace,) I can replicate the issue.

[marutim]

7277140-zen

Deactivated the Gutenberg plugin to fix the issue

[rosepajaroja]

7277204-zen-a8c

[rosepajaroja]

7276965

@rosepajaroja about this one: 7276965-zen -- I wonder if I missed anything. I don't see the user has AT site and the issue is on coupon code.

Thanks, @retnonindya! Updated it with the correct ticket ID.

[druesome]

7277667-zen

[mdtanjid0]

• 7277652-zen-a8c ( needs to follow up )

[mgozdis]

A couple of instances yesterday. Downgraded to PHP 7.4 on both instead of deactivating any plugins.
7299976-zd-a8c Waverly
7300006-zd-a8c Beleco

[villanovachile]

7302373-zd-a8c twentytwentytwo-swiss - child of twentytwentytwo

[tvolpert]

7275248-zd-a8c using twentytwentytwo

they reported the issue on Wednesday, and as far as I can tell it's actually cleared up on their site since then, we just hadn't gotten around to responding yet.

[villanovachile]

7302626-zd-a8c ueno

[pauljacobson]

Reported in 7298210-zen with a follow-up in 7298251-zen

Deactivated Gutenberg to mitigate the issue.

[simison]

@pauljacobson @villanovachile could you share the theme name for customers sites as well? Thanks!

[villanovachile]

@pauljacobson @villanovachile could you share the theme name for customers sites as well? Thanks!

Hi there

Yes, for 7302626-zd-a8c the theme was ueno

[arthur791004]

New wpcomsh release v3.13.60 is coming which should fix these temporarily:

twentytwentytwo-swiss
ueno

See https://github.com/Automattic/wpcomsh/pull/1566.

[jenlynnemc]

7304193-zen
Tried the deactivate, flush and activate, but that did not work, so I left gutenberg deactivated for now.
Theme was twentytwentytwo-blue

[arthur791004]

We released another upstream fix. Hence, when Gutenberg 17.0.2 is available, the issue should be resolved and we will revert the workaround (https://github.com/Automattic/wpcomsh/pull/1563, https://github.com/Automattic/wpcomsh/pull/1564, https://github.com/Automattic/wpcomsh/pull/1566) soon. See p58i-d4z-p2 for more details.

[jenlynnemc]

7306675-zen
Tried the deactivate, flush and activate, but that did not work, so I left gutenberg / classic editor deactivated for now.
Theme was Vetro.

[jenlynnemc]

7307909-zen
Tried the deactivate, flush and activate, but that did not work, so I left gutenberg / classic editor deactivated for now.
Theme was Ron.

[arthur791004]

Hi there, Gutenberg 17.0.2 is available on the atomic sites. If users still encounter this issue, we can try to upgrade their Gutenberg to the latest version to resolve this issue 🙂

[mdtanjid0]

The user, under ticket 7318641-zen, is using Gutenberg 17.0.2. Clearing the site cache did not resolve the issue, so it was necessary to keep the plugin deactivated.

[arthur791004]

The user, under ticket 7318641-zd-a8c, is using Gutenberg 17.0.2. Clearing the site cache did not resolve the issue, so it was necessary to keep the plugin deactivated.

@mdtanjid0 It looks weird as I cannot see the fatal errors mentioned in this issue from that site. Maybe this is another issue 🤔

[radtechgh]

user reports still seeing issue after upgrade to 17.0.2. Clear site cache, deactivate/reactivate didn't help. 7318070-zen

[edwinho89]

7322181-zd-a8c

Similar as above: Gutenberg v17.0.2 still having the issue.

[arthur791004]

7318070-zd-a8c
7322181-zd-a8c

These two seem to be another issue related to the CSS Syntax, WordPress/gutenberg#56082, as the errors are

CssSyntaxError: :699:17: Missed semicolon
CssSyntaxError: :58:1: Unknown word

[sudeepbaral]

• 7268530-zen

Similar issue here.
Theme: Byrne
Gutenberg Version: 17.0.2

Deactivating Gutenberg plugin fixed the issue.

[arthur791004]

7268530-zd-a8c

This is also the CSS Syntax issue. Could we create another issue to collect the CSS Syntax issue? Thanks!

[csabarakasz]

Many of us are seeing a CssSyntaxError with Missed semicolon that is different from this previous issue, so I created a new bug report: #84364

[arthur791004]

Thank you 💯

[mdtanjid0]

@mdtanjid0 It looks weird as I cannot see the fatal errors mentioned in this issue from that site. Maybe this is another issue 🤔

@arthur791004 It's possible, and I apologize for not verifying the exact fatal error on the site earlier. I did notice that editing the post wasn't possible without deactivating Gutenberg. Would you like me to take a closer look and check the specific error?

[zaguiini]

@arthur791004 The CSS errors are going to be fixed with this PR: WordPress/gutenberg#56093

[zaguiini]

@arthur791004, the PR WordPress/gutenberg#56093 is merged. Please, whenever it gets to Atomic, verify that it fixes the problem.

[arthur791004]

Closing this issue as the critical errors mentioned at the beginning are fixed in Gutenberg 17.0.2. Another issue related to CssSyntaxError will be resolved in Gutenberg 17.2 (or possibly in 17.1.1), and we can track the errors via #84364