Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Block: Missing padding when background image is set #82284

Closed
eduardozulian opened this issue Sep 27, 2023 · 1 comment
Closed

Group Block: Missing padding when background image is set #82284

eduardozulian opened this issue Sep 27, 2023 · 1 comment
Labels
[Closed] By design Behaviors that are functioning as designed. [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Gutenberg RC Testing [Platform] Simple [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@eduardozulian
Copy link
Member

Quick summary

When we set a background image, we don't add padding to the group so text is usually pretty close to the edges. In cases like this, it would be required to manually set the padding.

Steps to reproduce

  1. Add the group block
  2. Choose a background image
  3. Check the padding

What you expected to happen

The padding is to be set automatically just like we do in the Cover block or when we set a background color to a paragraph.

Captura de Tela 2023-09-27 às 16 17 29

What actually happened

Captura de Tela 2023-09-27 às 16 16 11

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@eduardozulian eduardozulian added [Type] Bug Needs triage Ticket needs to be triaged Gutenberg RC Testing [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Sep 27, 2023
@cuemarie
Copy link

📌 REPRODUCTION RESULTS

  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO
I believe this is by design - the Group block no longer automatically adds padding to content inside of it.

📌 ACTIONS

  • Closed as by design

📌 Message to Author
Hey @eduardozulian ! I think this is best suited as feedback in the Gutenberg issue where follow up issues to adding background images to Group blocks are being discussed. You could share that in the comments of the issue below, or submit a feature request to add padding when a background image is set.

@cuemarie cuemarie closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
@cuemarie cuemarie added Triaged To be used when issues have been triaged. [Closed] By design Behaviors that are functioning as designed. and removed Needs triage Ticket needs to be triaged labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] By design Behaviors that are functioning as designed. [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Gutenberg RC Testing [Platform] Simple [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

2 participants