Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent appearance for centered images in Columns and Layout Grids on various themes #80633

Open
jp-imagines opened this issue Aug 15, 2023 · 5 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@jp-imagines
Copy link

jp-imagines commented Aug 15, 2023

Quick summary

Tested on a few different block themes, both in the page editor and site/template editor. Depending on the theme, images that are resized and set to align center inside a column (Columns or Layout Grid) display differently in both the editor and the live site.

Initial report: 6669310-zd-a8c

Steps to reproduce

  1. Activate Twenty Twenty-Three.
  2. Create a new page which contains three separate column layouts:
  • A Columns block, where at least one column contains an Image block.
  • A Layout Grid block, where at least one column contains an Image block.
  • Same as the Layout Grid above, but the Image is contained within a Group block (i.e. Layout Grid > Column > Group > Image).
    In all cases, the image should be resized down and set to align center.
  1. Observe the image alignment in the editor and on the live page.
  2. Switch to Meraki. Observe the image alignment in the editor and on the live page.

What you expected to happen

Images in columns set to align center should be centered both in the editor and on the live site.

What actually happened

On Twenty Twenty-Three, an image in a Layout Grid only displays centered if contained in a Group (editor and live site):

tt3 editor
tt3 live

On Meraki, the images in any column never appear centered in the editor, but always appear centered on the live site:

meraki editor
meraki live

Background colors are for illustration purposes only; there's no change if the columns have no background colors set. Replicated similar behavior on other themes (e.g. Antonia behaves the same as Meraki).

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Might be related to WordPress/gutenberg#49542, but I'm not certain on that.

@jp-imagines jp-imagines added [Type] Bug Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Aug 15, 2023
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Atomic [Pri] High labels Aug 15, 2023
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6669310-zen
  • 7629774-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 15, 2023
@cuemarie cuemarie added [Pri] Normal User Report This issue was created following a WordPress customer report and removed [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Aug 15, 2023
@cuemarie
Copy link

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I'm able to replicate this across test environments using TT3.

In the linked GB issue, this comment seems to be highlighting the same underlying issue - the blocks in this report's tests match that problematic HTML markup: WordPress/gutenberg#49542 (comment)

Screenshots/Recordings

Atomic Site, TT3

Markup on 2023-08-16 at 16:28:15

Markup on 2023-08-16 at 16:29:16

📌 ACTIONS

📌 Message to Author

  • The Meraki issue looks to be something different, perhaps theme-specific with regard to the editor. On the live site, it looks like the theme's stylesheets are addressing the aligncenter issue, so the issue here is that the editor itself is not showing center alignment.
  • @jp-imagines would you be able to report that editor/live site discrepancy separately? Did you observe that across multiple themes, or just Meraki?

@cuemarie cuemarie added [Pri] Low [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Platform] Simple and removed [Pri] Normal Needs triage Ticket needs to be triaged labels Aug 16, 2023
@jp-imagines
Copy link
Author

would you be able to report that editor/live site discrepancy separately? Did you observe that across multiple themes, or just Meraki?

Multiple themes for both issues. In a quick test today:

  • Antonia, Byrne: behave the same as Meraki (not centered in the editor, all centered on the live site)
  • Pendant, Tazza, Loudness, Iotix: behave the same as TT3 (only Layout Grids affected)

Looks like the Meraki-like behavior is already reported in #78205. I'll add my findings there.

@cuemarie
Copy link

cuemarie commented Aug 17, 2023

Looks like the Meraki-like behavior is already reported in #78205. I'll add my findings there.

Ah, great find!

@renata-franco
Copy link

Another one here: 7629774-zen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

3 participants