-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existing Video Block Code Prevents Block Editor From Loading #58134
Comments
Very sorry if this is in the incorrect category. |
I am pretty sure this is related to another issue. Your user report indicated that the post titled Chapter 25 was one with a problem. I was able to replicate the problem, and when I opened it in the Classic Editor, I found there was a video at the very bottom of the post. Edit: It's definitely the video, I removed and re-added it and the post is fine now. |
@sophiegyo and I have been testing this and it looks like it is indeed a video block that is causing the editor to break. Some old posts have video blocks that seem to have been created with a previous version of the editor but are conflicting with the current version. Here is an example of the code that is found in these posts and prevents the editor from loading:
For reference, below is the code current the editor (Gutenberg: v11.8.3) will generate if you try to add a new video block now:
There are a few differences between the two codes but the first thing that caught my eyes was the escaped '/' in the video URL. In order to test this on a new post, I had to use the Classic editor, since the block editor will NOT let me add this code in the "Visual" editor and will delete the code if I try to add it via "Code Editor": Pasting this code inside an HTML block will also cause the editor to crash: We also noticed that pasting the offending code in the classic editor "unscapes" the URL, but the post will still not load via the block editor: Interestingly enough, the public post loads just fine. AT and Simple sites return the same results. Here are two examples:
I tested this on a local site with and without the Gutenberg plugin and the code does show as a broken block but does NOT crash the editor completely: To add it up, we need to figure out what has changed in the editor that makes it no longer compatible with video blocks added by previous Gutenberg versions and why it makes the entire editor to crash, as opposed to just showing a "broken block" message. |
cc @Automattic/greenhouse who have been making changes to the Video block recently. It would be interesting to figure out if this only happens on WordPress.com Simple, or if this also happens:
|
I'd have tested if I could :( Unfortunately it requires a page/post where the video was already added before whatever change triggered this, adding a video block now works just fine :/ |
We're working on a fix for this, should be a simple one and deployed soon. |
The blank editor issue should be fixed now, let us know if y'all still have any issues editing posts with video blocks. |
It does seem to be fixed now @roundhill, thank you for the quick response! |
Customer report of this issue on AT site - 4464349-zd-woothemes |
Thank you @rw-ye. I just retested this and I can confirm that is if fixed on simple sites but it is still breaking the editor on AT sites, @roundhill. Thank you! |
Yes, we discovered that it was also an issue on Atomic. It should be fixed today, I'll reply here when it is deployed! |
Apologies for the delay. The fix was deployed to Atomic-hosted sites at approximately 10:45 a.m. Central time (5 hours ago). Internal reference p9o2xV-1IJ-p2#comment-5280 |
Quick summary
The majority of the posts cannot be loaded on Block Editor on this simple site.
Ticket: 4460307zd
Steps to reproduce
What you expected to happen
The block editor should load.
What actually happened
For all the posts that do not load, no matter their title, the tab only says "50 Steps to Mastering Python Premium Content", which is the title of the website.
Some posts load with the blue WordPress.com Favicon. Some load with the orange WordPress.com favicon.
Some have a normal structure for a Block Editor post, even if they do not open.
Others have a very long link, similar to those from Classic Editor, like this one:
Classic Editor loads the pages. Another interesting thing is that it seems to be a bit random, as some post open sometimes and other times they don't.
Context
Customer report on their site.
Browser
Mozilla Firefox
Simple/Atomic
Simple
Other notes
Operating System
MacOS
OS Version
Monterrey 12.0.1.
Browser Version
Firefox 94.
Is this specific to the applied theme? If so, what is the theme name?
No, occurs regardless of theme.
Console and/or error logs
On posts that do load on Block Editor, I get this error:
On posts that do not load, I get this error:
On posts that load with the strange link (explained above), I get nothing:
Available Workarounds
They can use the classic editor but it appears that most of their pages were built with the block editor so that is less than ideal.
Reproducibility
Consistent
Severity
One
Available workarounds?
No and the platform is unusable
Workaround details
No response
The text was updated successfully, but these errors were encountered: