Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: v10.9.x plugin upgrade #53725

Closed
21 of 22 tasks
fullofcaffeine opened this issue Jun 15, 2021 · 2 comments
Closed
21 of 22 tasks

Gutenberg: v10.9.x plugin upgrade #53725

fullofcaffeine opened this issue Jun 15, 2021 · 2 comments
Assignees
Labels
gutenberg-upgrade To be used to classify Gutenberg upgrade tracking issues and make it easier to list them [Type] Task

Comments

@fullofcaffeine
Copy link
Contributor

fullofcaffeine commented Jun 15, 2021

Previous upgrade: #53394.
Release notes: v10.9.0-rc.1, v10.9.0, v10.9.1.

  • Install and activate
    • Copy & install v10.9.0-rc.1 (D62999-code, D63086-code) (It's a custom build with two additional fixes, see the description for the install diff)
    • Activate v10.9.0-rc.1 on edge (D63088-code)
    • Copy & install v10.9.0 (D63254-code, D63255-code)
    • Activate v10.9.0 on edge (D63256-code)
    • Activate v10.9.0 on production (D63089-code)
    • Copy and install v10.9.1 (D63347-code, D63352-code)
    • Activate v10.9.1 on edge (D63353-code)
    • Activate v10.9. on production (D63354-code)
    • Request AT upgrade
  • Testing
    • Desktop viewport E2E
    • Mobile viewport E2E
    • WPCOM (D63089-code, D63354-code)
  • Publish internal announcements
  • Clean up unused releases
  • Add log entry to the Gutenberg Upgrade Log [pcoGjb-g-p2]
  • Open a new issue for the next upgrade, transfer remaining tasks, close this issue.

Blockers 🙅‍♀️

Other issues 🐛

Transfered from previous release(s)

  • wp-components's index.js is broken by the WPCOM minifier. There's a hotfix (D61090-code, D61091-code) applied in the RC1 that allowed us to ship it to simple sites for now. We still don't know what exactly in v10.6.0 RC1 caused this. We might need to be hotfixing on simple sites while we don't have a perm. solution. See: p1620321684463200-slack-C02A41GCS and p1620319065221200-slack-C4GAP2RHD.
  • P2 inline comments broken (and potentially other P2-related issues). Reported here: p1620327615008700-slack-C025Q5RK2 cc @johngodley (P2s have been pinned to 10.5.4 for now, see: p1621258202222400/1620838719.129600-slack-C7YPUHBB2, which makes this issue not a blocker for now).

cc @inaikem @simison

@fullofcaffeine
Copy link
Contributor Author

fullofcaffeine commented Jun 30, 2021

Starting from 10.9, Gutenberg production builds include unminified and minified JS assets (introduced in WordPress/gutenberg#31732). For some reason, unminified jS assets have CRLF and LF bytes in them. This causes svn to complain in WPCOM (see: pMz3w-di5-p2#comment-89175).

We still don't know if this issue was already present and masked by the Terser plugin in Gutenberg, or if it was introduced in WordPress/gutenberg#31732. We'll investigate soon. For now, a workaround has been documented here: pMz3w-di5-p2#comment-89229, and should be done before we create the Gutenberg install diff in WPCOM.

@fullofcaffeine
Copy link
Contributor Author

This is done. Next one: #54180.

@fullofcaffeine fullofcaffeine added the gutenberg-upgrade To be used to classify Gutenberg upgrade tracking issues and make it easier to list them label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gutenberg-upgrade To be used to classify Gutenberg upgrade tracking issues and make it easier to list them [Type] Task
Projects
None yet
Development

No branches or pull requests

1 participant