Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse block display has changed following Gutenberg update #48772

Closed
kriskarkoski opened this issue Jan 11, 2021 · 6 comments
Closed

Verse block display has changed following Gutenberg update #48772

kriskarkoski opened this issue Jan 11, 2021 · 6 comments
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg [Type] Bug When a feature is broken and / or not performing as intended

Comments

@kriskarkoski
Copy link
Contributor

Following our update to Gutenberg 9.6.2 there are user reports of the look of the verse block has changed.

Steps to reproduce

  1. View a post containing a Verse block
  2. The look of the block has now changed from how it looked previously

What I expected

The update to have not impact on the look of the verse block.

What happened instead

The look of the block changed.

Initial report: 25707875-hc

@kriskarkoski kriskarkoski added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg labels Jan 11, 2021
@mikeicode
Copy link

Appears to be related to CSS white-space

How it currently looks:

https://d.pr/i/rGkNI3

After adding the following:

pre.wp-block-verse {
  white-space: unset;
  overflow:auto;
}

https://d.pr/i/ibvNfC

@sirreal
Copy link
Member

sirreal commented Jan 11, 2021

WordPress/gutenberg#27734 introduced a related change.

@carinapilar
Copy link

carinapilar commented Jan 11, 2021

Got another report on 14842845-hc

EDIT: the CSS only didn't fix the issue though, it shows all content without the original formatting.

@kathrynwp
Copy link
Member

Also ran into this in 26170324-hc - CSS workaround did the trick

@JoshuaGoode
Copy link

JoshuaGoode commented Jan 12, 2021

The change to fix this modifies white-space to use pre-wrap

Temporary workaround CSS for Atomic could look like the following for consistency.

 /* Resolve Verse block line-wrap rendering  */
 pre.wp-block-verse {
  white-space: pre-wrap;
}

@sirreal
Copy link
Member

sirreal commented Jan 15, 2021

This should be fixed for all users now.

@sirreal sirreal closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

6 participants